From 0289822e6c4e4782e7506d6ac156e0d756d7140b Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Wed, 17 Mar 2021 19:45:03 +0100 Subject: [PATCH] Fix binding loops that was sometimes freezing the app Fix #294 --- imports/NeoChat/Component/Timeline/TimelineContainer.qml | 3 ++- imports/NeoChat/Page/RoomPage.qml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/imports/NeoChat/Component/Timeline/TimelineContainer.qml b/imports/NeoChat/Component/Timeline/TimelineContainer.qml index 8f39bf6d9..816c3e97a 100644 --- a/imports/NeoChat/Component/Timeline/TimelineContainer.qml +++ b/imports/NeoChat/Component/Timeline/TimelineContainer.qml @@ -140,8 +140,9 @@ Item { // bubble QQC2.Control { id: controlContainer - //Layout.fillWidth: true + Layout.fillWidth: true Layout.maximumWidth: mainColumn.width - Kirigami.Units.gridUnit * 2 - Kirigami.Units.largeSpacing * 2 + Layout.preferredHeight: contentItem.implicitHeight topPadding: 0 bottomPadding: 0 leftPadding: 0 diff --git a/imports/NeoChat/Page/RoomPage.qml b/imports/NeoChat/Page/RoomPage.qml index 02dc21b35..aa10e98d7 100644 --- a/imports/NeoChat/Page/RoomPage.qml +++ b/imports/NeoChat/Page/RoomPage.qml @@ -196,6 +196,7 @@ Kirigami.ScrollablePage { model: !isLoaded ? undefined : sortedMessageEventModel + onContentYChanged: updateReadMarker() onCountChanged: updateReadMarker() @@ -590,7 +591,7 @@ Kirigami.ScrollablePage { currentRoom.getPreviousContent(50) } - positionViewAtBeginning() + positionViewAtBeginning(); } DropArea {