ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some useless checks

Browse Source
This commit is contained in:
Tobias Fella
2023-06-06 20:47:39 +02:00
parent 357b148944
commit 09025fa16d
2 changed files with 25 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/controller.cpp
View File

@@ -341,15 +341,9 @@ bool Controller::saveAccessTokenToKeyChain(const AccountSettings &account, const
void Controller::changeAvatar(Connection *conn, const QUrl &localFile) void Controller::changeAvatar(Connection *conn, const QUrl &localFile)
{ {
auto job = conn->uploadFile(localFile.toLocalFile()); auto job = conn->uploadFile(localFile.toLocalFile());
#ifdef QUOTIENT_07
if (isJobPending(job)) {
#else
if (isJobRunning(job)) {
#endif
connect(job, &BaseJob::success, this, [conn, job] { connect(job, &BaseJob::success, this, [conn, job] {
conn->callApi<SetAvatarUrlJob>(conn->userId(), job->contentUri()); conn->callApi<SetAvatarUrlJob>(conn->userId(), job->contentUri());
}); });
}
} }
void Controller::markAllMessagesAsRead(Connection *conn) void Controller::markAllMessagesAsRead(Connection *conn)

8
src/models/customemojimodel.cpp
View File

@@ -16,12 +16,6 @@
using namespace Quotient; using namespace Quotient;
#ifdef QUOTIENT_07
#define running isJobPending
#else
#define running isJobRunning
#endif
void CustomEmojiModel::fetchEmojis() void CustomEmojiModel::fetchEmojis()
{ {
if (!Controller::instance().activeConnection()) { if (!Controller::instance().activeConnection()) {
@@ -62,7 +56,6 @@ void CustomEmojiModel::addEmoji(const QString &name, const QUrl &location)
auto job = Controller::instance().activeConnection()->uploadFile(location.toLocalFile()); auto job = Controller::instance().activeConnection()->uploadFile(location.toLocalFile());
if (running(job)) {
connect(job, &BaseJob::success, this, [name, location, job] { connect(job, &BaseJob::success, this, [name, location, job] {
const auto &data = Controller::instance().activeConnection()->accountData("im.ponies.user_emotes"); const auto &data = Controller::instance().activeConnection()->accountData("im.ponies.user_emotes");
auto json = data != nullptr ? data->contentJson() : QJsonObject(); auto json = data != nullptr ? data->contentJson() : QJsonObject();
@@ -92,7 +85,6 @@ void CustomEmojiModel::addEmoji(const QString &name, const QUrl &location)
json["images"] = emojiData; json["images"] = emojiData;
Controller::instance().activeConnection()->setAccountData("im.ponies.user_emotes", json); Controller::instance().activeConnection()->setAccountData("im.ponies.user_emotes", json);
}); });
}
} }
void CustomEmojiModel::removeEmoji(const QString &name) void CustomEmojiModel::removeEmoji(const QString &name)