diff --git a/src/app/notificationsmanager.cpp b/src/app/notificationsmanager.cpp index 577fcaac5..11bf75ea1 100644 --- a/src/app/notificationsmanager.cpp +++ b/src/app/notificationsmanager.cpp @@ -38,7 +38,7 @@ NotificationsManager::NotificationsManager(QObject *parent) { } -void NotificationsManager::handleNotifications(QPointer connection) +void NotificationsManager::handleNotifications(const QPointer &connection) { if (KNotificationPermission::checkPermission() == Qt::PermissionStatus::Granted) { startNotificationJob(connection); @@ -68,7 +68,7 @@ void NotificationsManager::startNotificationJob(QPointer conn } } -void NotificationsManager::processNotificationJob(QPointer connection, Quotient::GetNotificationsJob *job, bool initialization) +void NotificationsManager::processNotificationJob(const QPointer &connection, const GetNotificationsJob *job, const bool initialization) { if (!job || !connection || !connection->isLoggedIn()) { return; @@ -159,7 +159,7 @@ void NotificationsManager::processNotificationJob(QPointer co } } -bool NotificationsManager::shouldPostNotification(QPointer connection, const QJsonValue ¬ification) +bool NotificationsManager::shouldPostNotification(const QPointer &connection, const QJsonValue ¬ification) { if (connection == nullptr || !connection->isLoggedIn()) { return false; @@ -198,7 +198,7 @@ void NotificationsManager::postNotification(NeoChatRoom *room, const QString &text, const QImage &icon, const QString &replyEventId, - bool canReply, + const bool canReply, qint64 timestamp) { const QString roomId = room->id(); @@ -283,7 +283,7 @@ void NotificationsManager::postInviteNotification(NeoChatRoom *rawRoom) } } -void NotificationsManager::doPostInviteNotification(QPointer room) +void NotificationsManager::doPostInviteNotification(const QPointer &room) { const auto roomMemberEvent = room->currentState().get(room->localMember().id()); if (roomMemberEvent == nullptr) { diff --git a/src/app/notificationsmanager.h b/src/app/notificationsmanager.h index d4cd552bf..7226158c7 100644 --- a/src/app/notificationsmanager.h +++ b/src/app/notificationsmanager.h @@ -58,7 +58,7 @@ public: /** * @brief Handle the notifications for the given connection. */ - void handleNotifications(QPointer connection); + void handleNotifications(const QPointer &connection); private: QHash m_initialTimestamp; @@ -68,7 +68,7 @@ private: void startNotificationJob(QPointer connection); static QPixmap createNotificationImage(const QImage &icon, NeoChatRoom *room); - bool shouldPostNotification(QPointer connection, const QJsonValue ¬ification); + bool shouldPostNotification(const QPointer &connection, const QJsonValue ¬ification); void postNotification(NeoChatRoom *room, const QString &sender, const QString &text, @@ -77,7 +77,7 @@ private: bool canReply, qint64 timestamp); - void doPostInviteNotification(QPointer room); + void doPostInviteNotification(const QPointer &room); QHash> m_notifications; QHash> m_invitations; @@ -85,5 +85,5 @@ private: bool permissionAsked = false; private Q_SLOTS: - void processNotificationJob(QPointer connection, Quotient::GetNotificationsJob *job, bool initialization); + void processNotificationJob(const QPointer &connection, const Quotient::GetNotificationsJob *job, bool initialization); };