Fix logout current connection crash

Make sure that the neochat can handle switching connection when the current one is logged out. This is mostly about using QPointer to handle use after free issues due to room objects being deleted.
This commit is contained in:
James Graham
2024-03-27 15:25:24 +00:00
parent 0ab8624d79
commit 0f9eb4beeb
7 changed files with 18 additions and 13 deletions

View File

@@ -629,6 +629,10 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
int MessageEventModel::eventIdToRow(const QString &eventID) const
{
if (m_currentRoom == nullptr) {
return -1;
}
const auto it = m_currentRoom->findInTimeline(eventID);
if (it == m_currentRoom->historyEdge()) {
// qWarning() << "Trying to find inexistent event:" << eventID;

View File

@@ -113,7 +113,7 @@ private Q_SLOTS:
void refreshRow(int row);
private:
NeoChatRoom *m_currentRoom = nullptr;
QPointer<NeoChatRoom> m_currentRoom = nullptr;
QString lastReadEventId;
QPersistentModelIndex m_lastReadEventIndex;
int rowBelowInserted = -1;

View File

@@ -61,7 +61,7 @@ public:
[[nodiscard]] QHash<int, QByteArray> roleNames() const override;
private:
NeoChatRoom *m_room = nullptr;
QPointer<NeoChatRoom> m_room = nullptr;
};
/**