From 1104da5e2c75ff6845bc91eadfc1aa85e2fe2783 Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Sat, 16 Nov 2024 15:52:39 -0500 Subject: [PATCH] TextHandler: Use the fancy Unicode quotation characters As per our HIG, we should use these in quotations instead of the normal quote characters. --- autotests/texthandlertest.cpp | 2 +- src/texthandler.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/autotests/texthandlertest.cpp b/autotests/texthandlertest.cpp index 4fd8f91f1..523b72f55 100644 --- a/autotests/texthandlertest.cpp +++ b/autotests/texthandlertest.cpp @@ -535,7 +535,7 @@ void TextHandlerTest::componentOutput_data() QVariantMap{{QStringLiteral("class"), QStringLiteral("html")}}}}; QTest::newRow("quote") << QStringLiteral("

Text

\n
\n

blockquote

\n
") << QList{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}, - MessageComponent{MessageComponentType::Quote, QStringLiteral("\"blockquote\""), {}}}; + MessageComponent{MessageComponentType::Quote, QStringLiteral("“blockquote”"), {}}}; QTest::newRow("no tag first paragraph") << QStringLiteral("Text\n

Text

") << QList{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}, MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}}; diff --git a/src/texthandler.cpp b/src/texthandler.cpp index 33be763a5..2f818534c 100644 --- a/src/texthandler.cpp +++ b/src/texthandler.cpp @@ -413,11 +413,11 @@ QString TextHandler::stripBlockTags(QString string, const QString &tagType) cons string.remove(0, string.indexOf(u'>') + 1); string.remove(string.indexOf(QLatin1String("

")), string.size()); } - if (!string.startsWith(u'"')) { - string.prepend(u'"'); + if (!string.startsWith(u'“')) { + string.prepend(u'“'); } - if (!string.endsWith(u'"')) { - string.append(u'"'); + if (!string.endsWith(u'”')) { + string.append(u'”'); } }