From 14167d197f0fed4ed112d4252fc3ca65d6fba465 Mon Sep 17 00:00:00 2001 From: Tobias Fella Date: Mon, 1 Sep 2025 23:33:25 +0200 Subject: [PATCH] Fix some qml warnings --- src/app/qml/CodeMaximizeComponent.qml | 4 ++-- src/settings/NotificationRuleItem.qml | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/app/qml/CodeMaximizeComponent.qml b/src/app/qml/CodeMaximizeComponent.qml index 6dfe6abfe..f415e78dc 100644 --- a/src/app/qml/CodeMaximizeComponent.qml +++ b/src/app/qml/CodeMaximizeComponent.qml @@ -48,7 +48,7 @@ Components.AbstractMaximizeComponent { implicitWidth: Kirigami.Units.iconSizes.medium implicitHeight: Kirigami.Units.iconSizes.medium - name: root.author.name ?? root.author.displayName + name: root.author.displayName source: root.author.avatarUrl color: root.author.color } @@ -57,7 +57,7 @@ Components.AbstractMaximizeComponent { QQC2.Label { id: userLabel - text: root.author.name ?? root.author.displayName + text: root.author.displayName color: root.author.color font.weight: Font.Bold elide: Text.ElideRight diff --git a/src/settings/NotificationRuleItem.qml b/src/settings/NotificationRuleItem.qml index c81bcc60c..d335ec092 100644 --- a/src/settings/NotificationRuleItem.qml +++ b/src/settings/NotificationRuleItem.qml @@ -41,14 +41,14 @@ FormCard.AbstractFormDelegate { Layout.minimumWidth: Kirigami.Units.gridUnit + Kirigami.Units.largeSpacing Layout.minimumHeight: Kirigami.Units.gridUnit + Kirigami.Units.largeSpacing - text: notificationsOn ? "" : "●" + text: root.notificationsOn ? "" : "●" color: Kirigami.Theme.textColor horizontalAlignment: Text.AlignHCenter background: Rectangle { - visible: notificationsOn + visible: root.notificationsOn Kirigami.Theme.colorSet: Kirigami.Theme.Button - color: highlightOn && highlightable ? Kirigami.Theme.positiveTextColor : Kirigami.Theme.disabledTextColor - opacity: highlightOn && highlightable ? 1 : 0.3 + color: root.highlightOn && root.highlightable ? Kirigami.Theme.positiveTextColor : Kirigami.Theme.disabledTextColor + opacity: root.highlightOn && root.highlightable ? 1 : 0.3 radius: height / 2 } } @@ -95,7 +95,7 @@ FormCard.AbstractFormDelegate { display: QQC2.AbstractButton.IconOnly checkable: true - checked: isNotificationRuleNoisy(root.ruleAction) + checked: root.isNotificationRuleNoisy(root.ruleAction) enabled: (onButton.checked || !root.notificationsOnModifiable) && root.enabled down: checked onToggled: {