From 1e892599e90ebe843c45db140854e950b94bf978 Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Sat, 9 Nov 2024 18:00:34 -0500 Subject: [PATCH] Improve clicking link previews First of all, clicking on them actually works - because we were missing an import for RoomManager. Secondly, we use a dedicated TapHandler since onLinkActivated sucks. We want to be able to click anywhere on the preview to go to the website/room anyway. (cherry picked from commit 69661590628777a720ab3dc7d2cb7cf5fb29ad19) --- src/timeline/LinkPreviewComponent.qml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/timeline/LinkPreviewComponent.qml b/src/timeline/LinkPreviewComponent.qml index f29af4116..bc40ba864 100644 --- a/src/timeline/LinkPreviewComponent.qml +++ b/src/timeline/LinkPreviewComponent.qml @@ -8,6 +8,8 @@ import QtQuick.Layouts import org.kde.kirigami as Kirigami +import org.kde.neochat + /** * @brief A component to show a link preview from a message. */ @@ -95,7 +97,6 @@ QQC2.Control { } " + (maximizeButton.checked ? root.linkPreviewer.title : titleTextMetrics.elidedText).replace("–", "—") + "" - onLinkActivated: RoomManager.resolveResource(link, "join") TextMetrics { id: titleTextMetrics @@ -120,6 +121,11 @@ QQC2.Control { elide: Text.ElideRight } } + + TapHandler { + acceptedButtons: Qt.LeftButton + onTapped: RoomManager.resolveResource(root.linkPreviewer.url, "join") + } } QQC2.Button {