From 244adf346708d2d4e1680590d30906e040d8e084 Mon Sep 17 00:00:00 2001 From: Reinhold Gschweicher Date: Fri, 27 Nov 2020 12:47:36 +0100 Subject: [PATCH] Generate "is typing" string only if someone is typing If no user is typing (currentRoom.userseTyping.length == 0) then don't generate the "is typing" string. Because the message box is invisible. This prefents error messages like: ``` kf.i18n: "1 instead of 2 arguments to message {%2 are typing} supplied before conversion." ``` Fixes: https://invent.kde.org/network/neochat/-/issues/80 --- imports/NeoChat/Page/RoomPage.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/imports/NeoChat/Page/RoomPage.qml b/imports/NeoChat/Page/RoomPage.qml index fd05ac36f..9df71e0e3 100644 --- a/imports/NeoChat/Page/RoomPage.qml +++ b/imports/NeoChat/Page/RoomPage.qml @@ -358,7 +358,7 @@ Kirigami.ScrollablePage { Layout.preferredHeight: Kirigami.Units.iconSizes.smallMedium } QQC2.Label { - text: i18ncp("Message displayed when some users are typing", "%2 is typing", "%2 are typing", currentRoom.usersTyping.length, currentRoom.usersTyping.map(user => user.displayName).join(", ")) + text: visible ? i18ncp("Message displayed when some users are typing", "%2 is typing", "%2 are typing", currentRoom.usersTyping.length, currentRoom.usersTyping.map(user => user.displayName).join(", ")) : "" } }