Remove NeoChatUser and just use Quotient::User this simplifies things and avoids casting from one to the other which address santizer didn't like

src/models/locationsmodel.cpp

@@ -61,7 +61,7 @@ void LocationsModel::addLocation(const RoomMessageEvent *event)
         .latitude = latitude,
         .longitude = longitude,
         .content = event->contentJson(),
-        .author = dynamic_cast<NeoChatUser *>(m_room->user(event->senderId())),
+        .author = m_room->user(event->senderId()),
     };
     endInsertRows();
 }

src/models/locationsmodel.h

@@ -10,6 +10,7 @@
 #include "neochatroom.h"
 
 #include <Quotient/events/roommessageevent.h>
+#include <Quotient/user.h>
 
 class LocationsModel : public QAbstractListModel
 {
@@ -51,7 +52,7 @@ private:
         float latitude;
         float longitude;
         QJsonObject content;
-        NeoChatUser *author;
+        Quotient::User *author;
     };
     QList<LocationData> m_locations;
     void addLocation(const Quotient::RoomMessageEvent *event);

src/models/messageeventmodel.cpp

@@ -25,7 +25,6 @@
 #include <KLocalizedString>
 
 #include "models/reactionmodel.h"
-#include "neochatuser.h"
 #include "texthandler.h"
 
 using namespace Quotient;
@@ -531,7 +530,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
     }
 
     if (role == AuthorRole) {
-        auto author = static_cast<NeoChatUser *>(isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId()));
+        auto author = isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId());
         return m_currentRoom->getUser(author);
     }
 
@@ -679,7 +678,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
         auto replyPtr = m_currentRoom->getReplyForEvent(evt);
 
         if (replyPtr) {
-            auto replyUser = static_cast<NeoChatUser *>(m_currentRoom->user(replyPtr->senderId()));
+            auto replyUser = m_currentRoom->user(replyPtr->senderId());
             return m_currentRoom->getUser(replyUser);
         } else {
             return m_currentRoom->getUser(nullptr);
@@ -808,7 +807,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
         QVariantList users;
         users.reserve(userIds.size());
         for (const auto &userId : userIds) {
-            auto user = static_cast<NeoChatUser *>(m_currentRoom->user(userId));
+            auto user = m_currentRoom->user(userId);
             users += m_currentRoom->getUser(user);
         }
 
@@ -836,7 +835,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
          */
         QString readMarkersString = i18np("1 user: ", "%1 users: ", userIds.size());
         for (const auto &userId : userIds) {
-            auto user = static_cast<NeoChatUser *>(m_currentRoom->user(userId));
+            auto user = m_currentRoom->user(userId);
             readMarkersString += user->displayname(m_currentRoom) + i18nc("list separator", ", ");
         }
         readMarkersString.chop(2);
@@ -877,7 +876,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
     }
 
     if (role == DisplayNameForInitialsRole) {
-        auto user = static_cast<NeoChatUser *>(isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId()));
+        auto user = isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId());
         return user->displayname(m_currentRoom).remove(QStringLiteral(" (%1)").arg(user->id()));
     }
 
@@ -889,7 +888,7 @@ QVariant MessageEventModel::data(const QModelIndex &idx, int role) const
             }
             return previousDisplayName;
         } else {
-            auto author = static_cast<NeoChatUser *>(isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId()));
+            auto author = isPending ? m_currentRoom->localUser() : m_currentRoom->user(evt.senderId());
             return m_currentRoom->htmlSafeMemberName(author->id());
         }
     }
@@ -1062,13 +1061,13 @@ void MessageEventModel::createReactionModelForEvent(const Quotient::RoomMessageE
         return;
     };
 
-    QMap<QString, QList<NeoChatUser *>> reactions = {};
+    QMap<QString, QList<Quotient::User *>> reactions = {};
     for (const auto &a : annotations) {
         if (a->isRedacted()) { // Just in case?
             continue;
         }
         if (const auto &e = eventCast<const ReactionEvent>(a)) {
-            reactions[e->key()].append(static_cast<NeoChatUser *>(m_currentRoom->user(e->senderId())));
+            reactions[e->key()].append(m_currentRoom->user(e->senderId()));
         }
     }
 
@@ -1095,7 +1094,7 @@ void MessageEventModel::createReactionModelForEvent(const Quotient::RoomMessageE
     if (m_reactionModels.contains(eventId)) {
         m_reactionModels[eventId]->setReactions(res);
     } else if (res.size() > 0) {
-        m_reactionModels[eventId] = new ReactionModel(this, res, static_cast<NeoChatUser *>(m_currentRoom->localUser()));
+        m_reactionModels[eventId] = new ReactionModel(this, res, m_currentRoom->localUser());
     } else {
         if (m_reactionModels.contains(eventId)) {
             delete m_reactionModels[eventId];

src/models/reactionmodel.cpp

@@ -7,9 +7,9 @@
 
 #include <KLocalizedString>
 
-#include "neochatuser.h"
+#include <Quotient/user.h>
 
-ReactionModel::ReactionModel(QObject *parent, QList<Reaction> reactions, NeoChatUser *localUser)
+ReactionModel::ReactionModel(QObject *parent, QList<Reaction> reactions, Quotient::User *localUser)
     : QAbstractListModel(parent)
     , m_localUser(localUser)
 {

src/models/reactionmodel.h

@@ -5,7 +5,10 @@
 
 #include <QAbstractListModel>
 
-class NeoChatUser;
+namespace Quotient
+{
+class User;
+}
 
 /**
  * @class ReactionModel
@@ -36,7 +39,7 @@ public:
         HasLocalUser, /**< Whether the local user is in the list of authors. */
     };
 
-    explicit ReactionModel(QObject *parent = nullptr, QList<Reaction> reactions = {}, NeoChatUser *localUser = nullptr);
+    explicit ReactionModel(QObject *parent = nullptr, QList<Reaction> reactions = {}, Quotient::User *localUser = nullptr);
 
     /**
      * @brief Get the given role value at the given index.
@@ -67,6 +70,6 @@ public:
 private:
     QList<Reaction> m_reactions;
 
-    NeoChatUser *m_localUser;
+    Quotient::User *m_localUser;
 };
 Q_DECLARE_METATYPE(ReactionModel *)

src/models/searchmodel.cpp

@@ -5,7 +5,6 @@
 
 #include "messageeventmodel.h"
 #include "neochatroom.h"
-#include "neochatuser.h"
 #include <Quotient/events/stickerevent.h>
 
 #include <KLocalizedString>
@@ -109,7 +108,7 @@ QVariant SearchModel::data(const QModelIndex &index, int role) const
         return false;
     case ReplyAuthorRole:
         if (const auto &replyPtr = m_room->getReplyForEvent(event)) {
-            return m_room->getUser(static_cast<NeoChatUser *>(m_room->user(replyPtr->senderId())));
+            return m_room->getUser(m_room->user(replyPtr->senderId()));
         } else {
             return m_room->getUser(nullptr);
         }

src/models/userlistmodel.cpp

@@ -71,8 +71,7 @@ QVariant UserListModel::data(const QModelIndex &index, int role) const
         return user->id();
     }
     if (role == AvatarRole) {
-        auto neoChatUser = static_cast<NeoChatUser *>(user);
-        return m_currentRoom->avatarForMember(neoChatUser);
+        return m_currentRoom->avatarForMember(user);
     }
     if (role == ObjectRole) {
         return QVariant::fromValue(user);