From 466cfd971d82142e177a5feaf8203ffb5d0514b8 Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Mon, 29 Sep 2025 16:14:22 -0400 Subject: [PATCH] Fix room succession not actually working I broke this in 409b6da160924a7c2b12c959ca81597a3a9a202c making it not possible to join a succeeding room. I decided to keep the old behavior of not prompting you to join, because: 1. You are intentionally choosing to tap the button. 2. Room successions aren't random, a privileged user in the room is creating it and there's already some implicit existing trust (Also the current join confirmation dialog isn't useful enough yet to make an actual informed decision anyway.) --- src/timeline/SuccessorDelegate.qml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/timeline/SuccessorDelegate.qml b/src/timeline/SuccessorDelegate.qml index 202e92cef..8af93f37f 100644 --- a/src/timeline/SuccessorDelegate.qml +++ b/src/timeline/SuccessorDelegate.qml @@ -27,7 +27,10 @@ TimelineDelegate { type: Kirigami.MessageType.Information actions: Kirigami.Action { text: i18n("See new room…") - onTriggered: RoomManager.resolveResource(root.room.successorId) + + // We want to skip the join confirmation check here, + // Not only because the user is intentionally tapping this button but the room is trusted to be the successor already + onTriggered: RoomManager.resolveResource(root.room.successorId, "join_confirmed") } } }