ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename indexforEventId to indexForEventId

Browse Source 
This is a simple change to ensure its properly camelCase.
This commit is contained in:
Joshua Goins
2026-01-11 17:20:35 -05:00
parent b45967508c
commit 58b47b8711
6 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
autotests/timelinemessagemodeltest.cpp
View File

@@ -208,7 +208,7 @@ void TimelineMessageModelTest::idToRow()
auto room = new TestUtils::TestRoom(connection, u"#myroom:kde.org"_s, u"test-min-sync.json"_s); auto room = new TestUtils::TestRoom(connection, u"#myroom:kde.org"_s, u"test-min-sync.json"_s);
model->setRoom(room); model->setRoom(room);
QCOMPARE(model->indexforEventId(u"$153456789:example.org"_s).row(), 0); QCOMPARE(model->indexForEventId(u"$153456789:example.org"_s).row(), 0);
} }
void TimelineMessageModelTest::cleanup() void TimelineMessageModelTest::cleanup()

2
src/timeline/TimelineView.qml
View File

@@ -40,7 +40,7 @@ QQC2.ScrollView {
* @brief Shift the view to the given event ID. * @brief Shift the view to the given event ID.
*/ */
function goToEvent(eventId) { function goToEvent(eventId) {
const index = messageListView.model.indexforEventId(eventId) const index = messageListView.model.indexForEventId(eventId)
if (!index.valid) { if (!index.valid) {
messageListView.positionViewAtEnd(); messageListView.positionViewAtEnd();
return; return;

4
src/timeline/models/messagefiltermodel.cpp
View File

@@ -125,7 +125,7 @@ QHash<int, QByteArray> MessageFilterModel::roleNames() const
return roles; return roles;
} }
QModelIndex MessageFilterModel::indexforEventId(const QString &eventId) const QModelIndex MessageFilterModel::indexForEventId(const QString &eventId) const
{ {
// Check if sourceModel is a message model. // Check if sourceModel is a message model.
auto messageModel = dynamic_cast<MessageModel *>(sourceModel()); auto messageModel = dynamic_cast<MessageModel *>(sourceModel());
@@ -141,7 +141,7 @@ QModelIndex MessageFilterModel::indexforEventId(const QString &eventId) const
} }
} }
auto eventIndex = messageModel->indexforEventId(eventId); auto eventIndex = messageModel->indexForEventId(eventId);
if (!eventIndex.isValid()) { if (!eventIndex.isValid()) {
return {}; return {};
} }

1
src/timeline/models/messagefiltermodel.h
View File

@@ -68,6 +68,7 @@ public:
* @brief Get the QModelIndex the given event ID in the model. * @brief Get the QModelIndex the given event ID in the model.
*/ */
Q_INVOKABLE QModelIndex indexforEventId(const QString &eventId) const; Q_INVOKABLE QModelIndex indexforEventId(const QString &eventId) const;
Q_INVOKABLE QModelIndex indexForEventId(const QString &eventId) const;
static void setShowAllEvents(bool enabled); static void setShowAllEvents(bool enabled);
static void setShowDeletedMessages(bool enabled); static void setShowDeletedMessages(bool enabled);

2
src/timeline/models/messagemodel.cpp
View File

@@ -349,7 +349,7 @@ QHash<int, QByteArray> MessageModel::roleNames() const
return roles; return roles;
} }
QModelIndex MessageModel::indexforEventId(const QString &eventId) const QModelIndex MessageModel::indexForEventId(const QString &eventId) const
{ {
if (m_room == nullptr) { if (m_room == nullptr) {
return {}; return {};

3
src/timeline/models/messagemodel.h
View File

@@ -113,9 +113,10 @@ public:
[[nodiscard]] QHash<int, QByteArray> roleNames() const override; [[nodiscard]] QHash<int, QByteArray> roleNames() const override;
/** /**
* @brief Get the QModelIndex of the given event ID in the model. * @brief Get the QModelIndex of the given event ID in the model, returning an invalid QModelIndex if no matches were found.
*/ */
Q_INVOKABLE QModelIndex indexforEventId(const QString &eventId) const; Q_INVOKABLE QModelIndex indexforEventId(const QString &eventId) const;
Q_INVOKABLE QModelIndex indexForEventId(const QString &eventId) const;
static void setHiddenFilter(std::function<bool(const Quotient::RoomEvent *)> hiddenFilter); static void setHiddenFilter(std::function<bool(const Quotient::RoomEvent *)> hiddenFilter);