From 59ae9fa18d5c2362d2985f7069f295e5b52ae722 Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Sun, 22 Nov 2020 11:56:19 +0100 Subject: [PATCH] Don't leak QSetting in emoji model --- src/emojimodel.cpp | 4 ++-- src/emojimodel.h | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/emojimodel.cpp b/src/emojimodel.cpp index 26df17617..4e7471307 100644 --- a/src/emojimodel.cpp +++ b/src/emojimodel.cpp @@ -11,7 +11,7 @@ QVariantList EmojiModel::history() { - return m_settings->value("Editor/emojis", QVariantList()).toList(); + return m_settings.value("Editor/emojis", QVariantList()).toList(); } QVariantList EmojiModel::filterModel(const QString &filter) @@ -83,7 +83,7 @@ void EmojiModel::emojiUsed(QVariant modelData) } list.push_front(modelData); - m_settings->setValue("Editor/emojis", list); + m_settings.setValue("Editor/emojis", list); Q_EMIT historyChanged(); } diff --git a/src/emojimodel.h b/src/emojimodel.h index 50dc43040..ae5ad537f 100644 --- a/src/emojimodel.h +++ b/src/emojimodel.h @@ -63,7 +63,6 @@ class EmojiModel : public QObject public: explicit EmojiModel(QObject *parent = nullptr) : QObject(parent) - , m_settings(new QSettings()) { } @@ -86,7 +85,7 @@ private: static const QVariantList symbols; static const QVariantList flags; - QSettings *m_settings; + QSettings m_settings; }; #endif // EMOJIMODEL_H