From 5aa7f499c0fc94fac17227d3f1eea211cd21ce54 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Sun, 21 Apr 2024 13:20:37 +0200 Subject: [PATCH] Make the "add new" menu button a hamburger menu I know hamburger menus sometimes aren't amazing, but the current icon is misleading. It's a plus button which generally means "create new". However the menu is full of actions not related to creating new things, including: - Explore Rooms - Find your Friends - Scan a QR Code These actions may technically result in a new room appearing in the sidebar, but that's not a user's definition of creating a new thing; these are *joining* a thing, and the fact that a new entry appears in the sidebar is an implementation detail. As a result the existing icon is inaccurate, and also holds back the menu from adding additional items in the future that are even less related to creating new rooms. An example would be the quick room switcher, which is not exposed visibly in the UI anywhere, and could not logically live in the current menu without changing its icon and text. (cherry picked from commit d9308440e6e6d45419964258dd20875ba61d7a13) --- src/qml/ExploreComponent.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qml/ExploreComponent.qml b/src/qml/ExploreComponent.qml index 43e085ff5..8f4029c63 100644 --- a/src/qml/ExploreComponent.qml +++ b/src/qml/ExploreComponent.qml @@ -100,8 +100,8 @@ RowLayout { display: QQC2.AbstractButton.IconOnly checkable: true action: Kirigami.Action { - text: i18n("Create rooms and chats") - icon.name: "irc-join-channel" + text: i18nc("@action:button", "Show Menu") + icon.name: "application-menu-symbolic" onTriggered: { if (Kirigami.isMobile) { const menu = mobileMenu.createObject();