Fix crashing when logging out.

That's a complex issue. Yay!

src/accountlistmodel.cpp

@@ -27,6 +27,8 @@ void AccountListModel::setController(Controller* value) {
 
     connect(m_controller, &Controller::connectionAdded, this,
             [=](Connection* conn) {
+              if (!conn) {
+              }
               beginInsertRows(QModelIndex(), m_connections.count(),
                               m_connections.count());
               m_connections.append(conn);
@@ -34,6 +36,12 @@ void AccountListModel::setController(Controller* value) {
             });
     connect(m_controller, &Controller::connectionDropped, this,
             [=](Connection* conn) {
+              qDebug() << "Dropping connection" << conn->userId();
+              if (!conn) {
+                qDebug() << "Trying to remove null connection";
+                return;
+              }
+              conn->disconnect(this);
               const auto it =
                   std::find(m_connections.begin(), m_connections.end(), conn);
               if (it == m_connections.end())
@@ -50,15 +58,18 @@ void AccountListModel::setController(Controller* value) {
 QVariant AccountListModel::data(const QModelIndex& index, int role) const {
   if (!index.isValid()) return QVariant();
 
-  if (index.row() >= m_controller->connections().count()) {
-    qDebug()
-        << "UserListModel, something's wrong: index.row() >= m_users.count()";
+  if (index.row() >= m_connections.count()) {
+    qDebug() << "AccountListModel, something's wrong: index.row() >= "
+                "m_users.count()";
     return QVariant();
   }
-  auto m_connection = m_controller->connections().at(index.row());
+  auto m_connection = m_connections.at(index.row());
   if (role == NameRole) {
     return m_connection->user()->displayname();
   }
+  if (role == AccountIDRole) {
+    return m_connection->user()->id();
+  }
   if (role == AvatarRole) {
     return m_connection->user()->avatar(64);
   }
@@ -78,6 +89,7 @@ int AccountListModel::rowCount(const QModelIndex& parent) const {
 QHash<int, QByteArray> AccountListModel::roleNames() const {
   QHash<int, QByteArray> roles;
   roles[NameRole] = "name";
+  roles[AccountIDRole] = "accountID";
   roles[AvatarRole] = "avatar";
   roles[ConnectionRole] = "connection";
   return roles;

src/accountlistmodel.h

@@ -11,7 +11,12 @@ class AccountListModel : public QAbstractListModel {
   Q_PROPERTY(Controller* controller READ controller WRITE setController NOTIFY
                  controllerChanged)
  public:
-  enum EventRoles { NameRole = Qt::UserRole + 1, AvatarRole, ConnectionRole };
+  enum EventRoles {
+    NameRole = Qt::UserRole + 1,
+    AccountIDRole,
+    AvatarRole,
+    ConnectionRole
+  };
 
   AccountListModel(QObject* parent = nullptr);
 

src/controller.cpp

@@ -40,13 +40,17 @@ Controller::Controller(QObject* parent) : QObject(parent) {
 
   Connection::setRoomType<MatriqueRoom>();
 
-  invokeLogin();
+  QTimer::singleShot(0, this, SLOT(invokeLogin()));
 }
 
-Controller::~Controller() {
-  //  m_connection->saveState();
-  //  m_connection->stopSync();
-  //  m_connection->deleteLater();
+Controller::~Controller() {}
+
+inline QString accessTokenFileName(const AccountSettings& account) {
+  QString fileName = account.userId();
+  fileName.replace(':', '_');
+  return QStandardPaths::writableLocation(
+             QStandardPaths::AppLocalDataLocation) +
+         '/' + fileName;
 }
 
 void Controller::loginWithCredentials(QString serverAddr, QString user,
@@ -70,18 +74,24 @@ void Controller::loginWithCredentials(QString serverAddr, QString user,
   }
 }
 
+void Controller::logout(Connection* conn) {
+  if (!conn) {
+    qCritical() << "Attempt to logout null connection";
+    return;
+  }
+
+  SettingsGroup("Accounts").remove(conn->userId());
+  QFile(accessTokenFileName(AccountSettings(conn->userId()))).remove();
+
+  conn->logout();
+}
+
 void Controller::addConnection(Connection* c) {
   Q_ASSERT_X(c, __FUNCTION__, "Attempt to add a null connection");
 
   m_connections.push_back(c);
 
   connect(c, &Connection::syncDone, this, [=] {
-    //        gotEvents(c);
-
-    // Borrowed the logic from Quiark's code in Tensor to cache not too
-    // aggressively and not on the first sync. The static variable instance
-    // is created per-closure, meaning per-connection (which is why this
-    // code is not in gotEvents() ).
     static int counter = 0;
     if (++counter % 17 == 2) c->saveState();
   });
@@ -98,23 +108,13 @@ void Controller::dropConnection(Connection* c) {
   Q_ASSERT_X(c, __FUNCTION__, "Attempt to drop a null connection");
   m_connections.removeOne(c);
 
-  Q_ASSERT(!m_connections.contains(c) && !c->syncJob());
-  emit connectionAdded(c);
+  emit connectionDropped(c);
   c->deleteLater();
 }
 
-inline QString accessTokenFileName(const AccountSettings& account) {
-  QString fileName = account.userId();
-  fileName.replace(':', '_');
-  return QStandardPaths::writableLocation(
-             QStandardPaths::AppLocalDataLocation) +
-         '/' + fileName;
-}
-
 void Controller::invokeLogin() {
   using namespace QMatrixClient;
   const auto accounts = SettingsGroup("Accounts").childGroups();
-  bool autoLoggedIn = false;
   for (const auto& accountId : accounts) {
     AccountSettings account{accountId};
     if (!account.homeserver().isEmpty()) {
@@ -130,7 +130,6 @@ void Controller::invokeLogin() {
         account.clearAccessToken();  // Clean the old place
       }
 
-      autoLoggedIn = true;
       auto c = new Connection(account.homeserver(), this);
       auto deviceName = account.deviceName();
       connect(c, &Connection::connected, this, [=] {
@@ -185,42 +184,20 @@ bool Controller::saveAccessToken(const AccountSettings& account,
   return false;
 }
 
-void Controller::connected() {
-  //  setHomeserver(m_connection->homeserver().toString());
-  //  setUserID(m_connection->userId());
-  //  setToken(m_connection->accessToken());
-  //  m_connection->loadState();
-  //  resync();
-  //  setIsLogin(true);
+void Controller::joinRoom(Connection* c, const QString& alias) {
+  JoinRoomJob* joinRoomJob = c->joinRoom(alias);
+  setBusy(true);
+  joinRoomJob->connect(joinRoomJob, &JoinRoomJob::finished,
+                       [=] { setBusy(false); });
 }
 
-void Controller::resync() { /*m_connection->sync(30000);*/
-}
-
-void Controller::reconnect() {
-  //  qDebug() << "Connection lost. Reconnecting...";
-  //  m_connection->connectWithToken(m_userID, m_token, "");
-}
-
-void Controller::joinRoom(const QString& alias) {
-  //  JoinRoomJob* joinRoomJob = m_connection->joinRoom(alias);
-  //  setBusy(true);
-  //  joinRoomJob->connect(joinRoomJob, &JoinRoomJob::finished,
-  //                       [=] { setBusy(false); });
-}
-
-void Controller::createRoom(const QString& name, const QString& topic) {
-  //  CreateRoomJob* createRoomJob =
-  //      ((Connection*)m_connection)
-  //          ->createRoom(Connection::PublishRoom, "", name, topic,
-  //          QStringList());
-  //  setBusy(true);
-  //  createRoomJob->connect(createRoomJob, &CreateRoomJob::finished,
-  //                         [=] { setBusy(false); });
-}
-
-void Controller::createDirectChat(const QString& userID) {
-  //  m_connection->requestDirectChat(userID);
+void Controller::createRoom(Connection* c, const QString& name,
+                            const QString& topic) {
+  CreateRoomJob* createRoomJob =
+      c->createRoom(Connection::PublishRoom, "", name, topic, QStringList());
+  setBusy(true);
+  createRoomJob->connect(createRoomJob, &CreateRoomJob::finished,
+                         [=] { setBusy(false); });
 }
 
 void Controller::copyToClipboard(const QString& text) {

src/controller.h

@@ -49,9 +49,6 @@ class Controller : public QObject {
 
   bool m_busy = false;
 
-  void connected();
-  void resync();
-  void reconnect();
   QByteArray loadAccessToken(const AccountSettings& account);
   bool saveAccessToken(const AccountSettings& account,
                        const QByteArray& accessToken);
@@ -69,9 +66,9 @@ class Controller : public QObject {
   void connectionDropped(Connection* conn);
 
  public slots:
-  void joinRoom(const QString& alias);
-  void createRoom(const QString& name, const QString& topic);
-  void createDirectChat(const QString& userID);
+  void logout(Connection* conn);
+  void joinRoom(Connection* c, const QString& alias);
+  void createRoom(Connection* c, const QString& name, const QString& topic);
   void copyToClipboard(const QString& text);
   void playAudio(QUrl localFile);
   void showMessage(const QString& title, const QString& msg, const QIcon& icon);

src/messageeventmodel.cpp

@@ -51,7 +51,6 @@ void MessageEventModel::setRoom(MatriqueRoom* room) {
   beginResetModel();
   if (m_currentRoom) {
     m_currentRoom->disconnect(this);
-    qDebug() << "Disconnected from" << m_currentRoom->id();
   }
 
   m_currentRoom = room;

src/roomlistmodel.cpp

@@ -14,7 +14,16 @@ RoomListModel::RoomListModel(QObject* parent) : QAbstractListModel(parent) {}
 RoomListModel::~RoomListModel() {}
 
 void RoomListModel::setConnection(Connection* connection) {
-  if (!connection && connection == m_connection) return;
+  if (connection == m_connection) return;
+  if (!connection) {
+    qDebug() << "Removing current connection...";
+    m_connection->disconnect(this);
+    m_connection = nullptr;
+    beginResetModel();
+    m_rooms.clear();
+    endResetModel();
+    return;
+  }
 
   using QMatrixClient::Room;
   m_connection = connection;