ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix keyboard navigation in space drawer

Browse Source 
Some of the items were able to activated via the keyboard, but many were
not like the notifications and "create a space" buttons. This is because
the signals were hooked up to onClicked but the accessible and keyboard
nav were hooked up to onSelected. All of the buttons trigger their
actions with onSelected now.

(cherry picked from commit 277a4ad124)
This commit is contained in:
Joshua Goins
2024-06-08 11:20:17 -04:00
parent b097f1c0ec
commit 67f5c0b1ed
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/qml/SpaceDrawer.qml
View File

@@ -62,7 +62,7 @@ QQC2.Control {
activeFocusOnTab: true
onClicked: pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'NotificationsView'), {
onSelected: pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'NotificationsView'), {
connection: root.connection
}, {
title: i18nc("@title", "Notifications")
@@ -91,7 +91,7 @@ QQC2.Control {
activeFocusOnTab: true
checked: RoomManager.currentSpace.length === 0
onClicked: {
onSelected: {
RoomManager.currentSpace = "";
root.selectionChanged();
}
@@ -139,7 +139,7 @@ QQC2.Control {
activeFocusOnTab: true
checked: RoomManager.currentSpace === "DM"
onClicked: {
onSelected: {
RoomManager.currentSpace = "DM";
root.selectionChanged();
}
@@ -241,7 +241,7 @@ QQC2.Control {
text: i18nc("Join <name of a space>", "Join %1", SpaceHierarchyCache.recommendedSpaceDisplayName)
source: SpaceHierarchyCache.recommendedSpaceAvatar.length > 0 ? root.connection.makeMediaUrl(SpaceHierarchyCache.recommendedSpaceAvatar) : ""
onClicked: {
onSelected: {
recommendedSpaceDialogComponent.createObject(QQC2.ApplicationWindow.overlay, {
connection: root.connection
}).open();
@@ -288,7 +288,7 @@ QQC2.Control {
activeFocusOnTab: true
onClicked: pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'CreateRoomDialog'), {
onSelected: pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'CreateRoomDialog'), {
connection: root.connection,
isSpace: true,
title: i18nc("@title", "Create a Space")