ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comment about push rule check in contextAwareNotificationCount()

Browse Source 
I thought this was unnecessary as the push rules should take care of it
for us, but that's not entirely true. I added a comment to reflect this
reality.
This commit is contained in:
Joshua Goins
2025-02-21 20:14:53 -05:00
parent 537ce772af
commit 72416884d4
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libneochat/neochatroom.cpp
View File

@@ -190,13 +190,15 @@ void NeoChatRoom::setVisible(bool visible)
int NeoChatRoom::contextAwareNotificationCount() const int NeoChatRoom::contextAwareNotificationCount() const
{ {
// DOn't include spaces, rooms that the user hasn't joined and rooms where the user has joined the successor. // Don't include spaces, rooms that the user hasn't joined and rooms where the user has joined the successor.
if (isSpace() || joinState() != JoinState::Join || successor(JoinState::Join) != nullptr) { if (isSpace() || joinState() != JoinState::Join || successor(JoinState::Join) != nullptr) {
return 0; return 0;
} }
if (m_currentPushNotificationState == PushNotificationState::Mute) { if (m_currentPushNotificationState == PushNotificationState::Mute) {
return 0; return 0;
} }
// There is (currently) no association between our highlight count and the associated push rule,
// so we need this check here otherwise everything appears out-of-sync.
if (m_currentPushNotificationState == PushNotificationState::MentionKeyword || isLowPriority()) { if (m_currentPushNotificationState == PushNotificationState::MentionKeyword || isLowPriority()) {
return int(highlightCount()); return int(highlightCount());
} }