Use const'ref

src/actionshandler.h

@@ -47,7 +47,7 @@ public:
 
 Q_SIGNALS:
     void roomChanged();
-    void showEffect(QString effect);
+    void showEffect(const QString &effect);
 
 public Q_SLOTS:
 

src/filetransferpseudojob.cpp

@@ -14,7 +14,7 @@ FileTransferPseudoJob::FileTransferPseudoJob(Operation operation, const QString
 {
 }
 
-void FileTransferPseudoJob::fileTransferProgress(QString id, qint64 progress, qint64 total)
+void FileTransferPseudoJob::fileTransferProgress(const QString &id, qint64 progress, qint64 total)
 {
     if (id != m_eventId) {
         return;
@@ -23,7 +23,7 @@ void FileTransferPseudoJob::fileTransferProgress(QString id, qint64 progress, qi
     setTotalAmount(Unit::Bytes, total);
 }
 
-void FileTransferPseudoJob::fileTransferCompleted(QString id, QUrl localFile)
+void FileTransferPseudoJob::fileTransferCompleted(const QString &id, const QUrl &localFile)
 {
     Q_UNUSED(localFile);
     if (id != m_eventId) {
@@ -32,7 +32,7 @@ void FileTransferPseudoJob::fileTransferCompleted(QString id, QUrl localFile)
     emitResult();
 }
 
-void FileTransferPseudoJob::fileTransferFailed(QString id, QString errorMessage)
+void FileTransferPseudoJob::fileTransferFailed(const QString &id, const QString &errorMessage)
 {
     if (id != m_eventId) {
         return;

src/filetransferpseudojob.h

@@ -26,17 +26,17 @@ public:
     /**
      * @brief Set the current number of bytes transferred.
      */
-    void fileTransferProgress(QString id, qint64 progress, qint64 total);
+    void fileTransferProgress(const QString &id, qint64 progress, qint64 total);
 
     /**
      * @brief Set the file transfer as complete.
      */
-    void fileTransferCompleted(QString id, QUrl localFile);
+    void fileTransferCompleted(const QString &id, const QUrl &localFile);
 
     /**
      * @brief Set the file transfer as failed.
      */
-    void fileTransferFailed(QString id, QString errorMessage = {});
+    void fileTransferFailed(const QString &id, const QString &errorMessage = {});
 
     /**
      * @brief Start the file transfer.

src/linkpreviewer.cpp

@@ -10,7 +10,7 @@
 
 using namespace Quotient;
 
-LinkPreviewer::LinkPreviewer(QObject *parent, NeoChatRoom *room, QUrl url)
+LinkPreviewer::LinkPreviewer(QObject *parent, NeoChatRoom *room, const QUrl &url)
     : QObject(parent)
     , m_currentRoom(room)
     , m_loaded(false)

src/linkpreviewer.h

@@ -45,7 +45,7 @@ class LinkPreviewer : public QObject
     Q_PROPERTY(QUrl imageSource READ imageSource NOTIFY imageSourceChanged)
 
 public:
-    explicit LinkPreviewer(QObject *parent = nullptr, NeoChatRoom *room = nullptr, QUrl url = {});
+    explicit LinkPreviewer(QObject *parent = nullptr, NeoChatRoom *room = nullptr, const QUrl &url = {});
 
     [[nodiscard]] QUrl url() const;
     void setUrl(QUrl);

src/login.h

@@ -112,7 +112,7 @@ Q_SIGNALS:
     void loginFlowsChanged();
     void ssoUrlChanged();
     void connected();
-    void errorOccured(QString message);
+    void errorOccured(const QString &message);
     void testingChanged();
     void isLoggingInChanged();
     void isLoggedInChanged();