From 89e5a605c49bf923967e19c89bc31b90f988dca3 Mon Sep 17 00:00:00 2001 From: James Graham Date: Sun, 15 Feb 2026 11:27:32 +0000 Subject: [PATCH] Basically we were applying the default values onComponentComplete therefore overriding any user value. This patch applies the default on creation before properties are set so the user can now override. --- src/timeline/timelinedelegate.cpp | 9 +++++++-- src/timeline/timelinedelegate.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/timeline/timelinedelegate.cpp b/src/timeline/timelinedelegate.cpp index 553d23a1b..4d2d70107 100644 --- a/src/timeline/timelinedelegate.cpp +++ b/src/timeline/timelinedelegate.cpp @@ -109,9 +109,9 @@ void TimelineDelegate::geometryChange(const QRectF &newGeometry, const QRectF &o QQuickItem::geometryChange(newGeometry, oldGeometry); } -void TimelineDelegate::componentComplete() +void TimelineDelegate::classBegin() { - QQuickItem::componentComplete(); + QQuickItem::classBegin(); auto engine = qmlEngine(this); Q_ASSERT(engine); @@ -121,6 +121,11 @@ void TimelineDelegate::componentComplete() connect(m_units, &Kirigami::Platform::Units::largeSpacingChanged, this, &TimelineDelegate::setCurveValues); connect(m_units, &Kirigami::Platform::Units::smallSpacingChanged, this, &TimelineDelegate::setCurveValues); setCurveValues(); +} + +void TimelineDelegate::componentComplete() +{ + QQuickItem::componentComplete(); if (m_isDirty) { resizeContent(); diff --git a/src/timeline/timelinedelegate.h b/src/timeline/timelinedelegate.h index 8d76c895e..02517750f 100644 --- a/src/timeline/timelinedelegate.h +++ b/src/timeline/timelinedelegate.h @@ -95,6 +95,7 @@ protected: bool m_resizingContent = false; private: + void classBegin() override; void componentComplete() override; void geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry) override; void updatePolish() override;