diff --git a/autotests/eventhandlertest.cpp b/autotests/eventhandlertest.cpp index 412c78b5a..13a4e2c58 100644 --- a/autotests/eventhandlertest.cpp +++ b/autotests/eventhandlertest.cpp @@ -99,8 +99,9 @@ void EventHandlerTest::time() { const auto event = room->messageEvents().at(0).get(); - QCOMPARE(EventHandler::time(event), QDateTime::fromMSecsSinceEpoch(1432735824654, Qt::UTC)); - QCOMPARE(EventHandler::time(event, true, QDateTime::fromMSecsSinceEpoch(1234, Qt::UTC)), QDateTime::fromMSecsSinceEpoch(1234, Qt::UTC)); + QCOMPARE(EventHandler::time(event), QDateTime::fromMSecsSinceEpoch(1432735824654, QTimeZone(QTimeZone::UTC))); + QCOMPARE(EventHandler::time(event, true, QDateTime::fromMSecsSinceEpoch(1234, QTimeZone(QTimeZone::UTC))), + QDateTime::fromMSecsSinceEpoch(1234, QTimeZone(QTimeZone::UTC))); } void EventHandlerTest::nullTime() @@ -119,19 +120,19 @@ void EventHandlerTest::timeString() KFormat format; QCOMPARE(EventHandler::timeString(event, false), - QLocale().toString(QDateTime::fromMSecsSinceEpoch(1432735824654, Qt::UTC).toLocalTime().time(), QLocale::ShortFormat)); + QLocale().toString(QDateTime::fromMSecsSinceEpoch(1432735824654, QTimeZone(QTimeZone::UTC)).toLocalTime().time(), QLocale::ShortFormat)); QCOMPARE(EventHandler::timeString(event, true), - format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1432735824654, Qt::UTC).toLocalTime().date(), QLocale::ShortFormat)); - QCOMPARE(EventHandler::timeString(event, false, QLocale::ShortFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC)), - QLocale().toString(QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC).toLocalTime().time(), QLocale::ShortFormat)); - QCOMPARE(EventHandler::timeString(event, true, QLocale::ShortFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC)), - format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC).toLocalTime().date(), QLocale::ShortFormat)); - QCOMPARE(EventHandler::timeString(event, false, QLocale::LongFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC)), - QLocale().toString(QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC).toLocalTime().time(), QLocale::LongFormat)); - QCOMPARE(EventHandler::timeString(event, true, QLocale::LongFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC)), - format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1690699214545, Qt::UTC).toLocalTime().date(), QLocale::LongFormat)); + format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1432735824654, QTimeZone(QTimeZone::UTC)).toLocalTime().date(), QLocale::ShortFormat)); + QCOMPARE(EventHandler::timeString(event, false, QLocale::ShortFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC))), + QLocale().toString(QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC)).toLocalTime().time(), QLocale::ShortFormat)); + QCOMPARE(EventHandler::timeString(event, true, QLocale::ShortFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC))), + format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC)).toLocalTime().date(), QLocale::ShortFormat)); + QCOMPARE(EventHandler::timeString(event, false, QLocale::LongFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC))), + QLocale().toString(QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC)).toLocalTime().time(), QLocale::LongFormat)); + QCOMPARE(EventHandler::timeString(event, true, QLocale::LongFormat, true, QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC))), + format.formatRelativeDate(QDateTime::fromMSecsSinceEpoch(1690699214545, QTimeZone(QTimeZone::UTC)).toLocalTime().date(), QLocale::LongFormat)); QCOMPARE(EventHandler::timeString(event, QStringLiteral("hh:mm")), - QDateTime::fromMSecsSinceEpoch(1432735824654, Qt::UTC).toString(QStringLiteral("hh:mm"))); + QDateTime::fromMSecsSinceEpoch(1432735824654, QTimeZone(QTimeZone::UTC)).toString(QStringLiteral("hh:mm"))); } void EventHandlerTest::highlighted() diff --git a/src/colorschemer.cpp b/src/colorschemer.cpp index e54e6da14..e0dbeea88 100644 --- a/src/colorschemer.cpp +++ b/src/colorschemer.cpp @@ -8,7 +8,6 @@ ColorSchemer::ColorSchemer(QObject *parent) : QObject(parent) - , c(new KColorSchemeManager(this)) { } @@ -18,17 +17,17 @@ ColorSchemer::~ColorSchemer() QAbstractItemModel *ColorSchemer::model() const { - return c->model(); + return KColorSchemeManager::instance()->model(); } void ColorSchemer::apply(int idx) { - c->activateScheme(c->model()->index(idx, 0)); + KColorSchemeManager::instance()->activateScheme(KColorSchemeManager::instance()->model()->index(idx, 0)); } int ColorSchemer::indexForCurrentScheme() { - return c->indexForSchemeId(c->activeSchemeId()).row(); + return KColorSchemeManager::instance()->indexForSchemeId(KColorSchemeManager::instance()->activeSchemeId()).row(); } #include "moc_colorschemer.cpp" diff --git a/src/colorschemer.h b/src/colorschemer.h index fae7910c4..16a580d58 100644 --- a/src/colorschemer.h +++ b/src/colorschemer.h @@ -49,7 +49,4 @@ public: * @sa KColorScheme */ Q_INVOKABLE int indexForCurrentScheme(); - -private: - KColorSchemeManager *c; }; diff --git a/src/linkpreviewer.cpp b/src/linkpreviewer.cpp index f85913380..f426c72da 100644 --- a/src/linkpreviewer.cpp +++ b/src/linkpreviewer.cpp @@ -4,11 +4,12 @@ #include "linkpreviewer.h" #include +#include #include + #include #include "neochatconfig.h" -#include "neochatconnection.h" #include "utils.h" using namespace Quotient; @@ -61,7 +62,13 @@ void LinkPreviewer::loadUrlPreview() if (conn == nullptr) { return; } - GetUrlPreviewJob *job = conn->callApi(m_url); + + BaseJob *job = nullptr; + if (conn->supportedMatrixSpecVersions().contains("v1.11"_L1)) { + job = conn->callApi(m_url); + } else { + QT_IGNORE_DEPRECATIONS(job = conn->callApi(m_url);) + } connect(job, &BaseJob::success, this, [this, job, conn]() { const auto json = job->jsonData(); diff --git a/src/models/messagecontentmodel.cpp b/src/models/messagecontentmodel.cpp index 97fcf91e1..43633c988 100644 --- a/src/models/messagecontentmodel.cpp +++ b/src/models/messagecontentmodel.cpp @@ -612,6 +612,7 @@ QList MessageContentModel::componentsForType(MessageComponentT } } } + [[fallthrough]]; default: return {MessageComponent{type, QString(), {}}}; } diff --git a/src/pollhandler.cpp b/src/pollhandler.cpp index 30911e220..4dc0c71bb 100644 --- a/src/pollhandler.cpp +++ b/src/pollhandler.cpp @@ -168,9 +168,8 @@ void PollHandler::sendPollAnswer(const QString &eventId, const QString &answerId ownAnswers.insert(0, answerId); } - auto response = new PollResponseEvent(eventId, ownAnswers); + const auto &response = room->post(eventId, ownAnswers); handleAnswer(response->contentJson(), room->localMember().id(), QDateTime::currentDateTime()); - room->postEvent(response); } bool PollHandler::hasEnded() const