From 9347a66acf59c91f3eefc98900b332e32373c03f Mon Sep 17 00:00:00 2001
From: Carl Schwan <carl@carlschwan.eu>
Date: Wed, 9 Oct 2024 23:23:29 +0200
Subject: [PATCH] RoomGeneralPage: Add missing separator

And some other minor fixes

(cherry picked from commit 00c5aa26bb58ba951f20787abdc56fa95f8daf3e)
---
 src/settings/RoomGeneralPage.qml | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/settings/RoomGeneralPage.qml b/src/settings/RoomGeneralPage.qml
index 3a94a9066..eb70ef665 100644
--- a/src/settings/RoomGeneralPage.qml
+++ b/src/settings/RoomGeneralPage.qml
@@ -70,17 +70,23 @@ FormCard.FormCardPage {
             readOnly: !room.canSendState("m.room.name")
         }
 
+        FormCard.FormDelegateSeparator {}
+
         FormCard.FormTextAreaDelegate {
             id: roomTopicField
             label: i18n("Room topic:")
-            Accessible.description: roomTopicLabel.text
             text: room.topic
             readOnly: !room.canSendState("m.room.topic")
             onTextChanged: roomTopicField.text = text
         }
+
+        FormCard.FormDelegateSeparator {
+            visible: !roomNameField.readOnly || !roomTopicField.readOnly
+        }
+
         FormCard.AbstractFormDelegate {
-            visible: !roomNameField.readOnly || !roomTopicTextArea.readOnly
-            background: Item {}
+            visible: !roomNameField.readOnly || !roomTopicField.readOnly
+            background: null
             contentItem: RowLayout {
                 Item {
                     Layout.fillWidth: true
@@ -90,6 +96,7 @@ FormCard.FormCardPage {
                     Layout.topMargin: Kirigami.Units.smallSpacing
                     enabled: room.name !== roomNameField.text || room.topic !== roomTopicField.text
                     text: i18n("Save")
+                    icon.name: "document-save-symbolic"
                     onClicked: {
                         if (room.name != roomNameField.text) {
                             room.setName(roomNameField.text);