From a27c8971b96488f4f14df8839b93ad882cdb379c Mon Sep 17 00:00:00 2001
From: Joshua Goins <josh@redstrate.com>
Date: Sat, 21 Feb 2026 11:53:47 -0500
Subject: [PATCH] Fix TimelineEnd/TimelineBeginning models properly this time

Amends 3b00e14a9d7943fc2a92e86b9bafc65c14b71b73 with a fix that's more
sensible, as we need to take into account the various checks before
mindlessly inserting roles.
---
 src/timeline/models/timelinemodel.cpp | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/src/timeline/models/timelinemodel.cpp b/src/timeline/models/timelinemodel.cpp
index 565bc2e46..b1fb177a1 100644
--- a/src/timeline/models/timelinemodel.cpp
+++ b/src/timeline/models/timelinemodel.cpp
@@ -79,9 +79,10 @@ void TimelineBeginningModel::setRoom(NeoChatRoom *room)
     if (m_room != nullptr) {
         Quotient::connectUntil(m_room.get(), &Quotient::Room::eventsHistoryJobChanged, this, [this]() {
             if (m_room && m_room->allHistoryLoaded()) {
-                Q_EMIT dataChanged(index(0, 0), index(0, 0), {DelegateTypeRole});
-                beginInsertRows({}, 1, 1);
-                endInsertRows();
+                if (!m_room->successorId().isEmpty()) {
+                    beginInsertRows({}, 1, 1);
+                    endInsertRows();
+                }
                 return true;
             }
             return false;
@@ -147,14 +148,16 @@ void TimelineEndModel::setRoom(NeoChatRoom *room)
     m_room = room;
 
     if (m_room != nullptr) {
-        connect(m_room, &Quotient::Room::eventsHistoryJobChanged, this, [this]() {
-            if (m_room->allHistoryLoaded()) {
-                // HACK: We have to do it this way because DelegateChooser doesn't update dynamically.
-                beginRemoveRows({}, 0, 0);
-                endRemoveRows();
-                beginInsertRows({}, 0, 0);
-                endInsertRows();
+        Quotient::connectUntil(m_room.get(), &Quotient::Room::eventsHistoryJobChanged, this, [this]() {
+            if (m_room && m_room->allHistoryLoaded()) {
+                Q_EMIT dataChanged(index(0, 0), index(0, 0), {DelegateTypeRole});
+                if (!m_room->predecessorId().isEmpty()) {
+                    beginInsertRows({}, 1, 1);
+                    endInsertRows();
+                }
+                return true;
             }
+            return false;
         });
     }
 
@@ -171,9 +174,8 @@ QVariant TimelineEndModel::data(const QModelIndex &idx, int role) const
     if (role == DelegateTypeRole) {
         if (idx.row() == 1 || rowCount() == 1) {
             return m_room->allHistoryLoaded() ? DelegateType::TimelineEnd : DelegateType::Loading;
-        } else {
-            return DelegateType::Predecessor;
         }
+        return DelegateType::Predecessor;
     }
 
     if (role == MessageModel::RoomRole) {