From abf9a486d0875a67e6e7ed0e2a4e340ef36824a0 Mon Sep 17 00:00:00 2001 From: Tobias Fella Date: Mon, 15 Sep 2025 13:49:08 +0200 Subject: [PATCH] Fix qml warnings in RoomData --- src/devtools/RoomData.qml | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/devtools/RoomData.qml b/src/devtools/RoomData.qml index 01a4b847a..5b175b49e 100644 --- a/src/devtools/RoomData.qml +++ b/src/devtools/RoomData.qml @@ -1,6 +1,8 @@ // SPDX-FileCopyrightText: 2022 James Graham // SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL +pragma ComponentBehavior: Bound + import QtQuick import QtQuick.Layouts import QtQuick.Window @@ -25,7 +27,7 @@ ColumnLayout { description: i18nc("@info", "Click to choose a room"); onClicked: { - let dialog = root.Window.window.pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'ChooseRoomDialog'), { + let dialog = (root.Kirigami.PageStack.pageStack as Kirigami.PageRow).pushDialogLayer(Qt.createComponent('org.kde.neochat', 'ChooseRoomDialog'), { connection: root.connection, }, { title: i18nc("@title:dialog", "Choose Room"), @@ -49,8 +51,9 @@ ColumnLayout { id: roomAccountData model: root.room.accountDataEventTypes delegate: FormCard.FormButtonDelegate { + required property string modelData text: modelData - onClicked: root.Window.window.pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'MessageSourceSheet'), { + onClicked: (root.Kirigami.PageStack.pageStack as Kirigami.PageRow).pushDialogLayer(Qt.createComponent('org.kde.neochat', 'MessageSourceSheet'), { sourceText: root.room.roomAcountDataJson(text) }, { title: i18n("Event Source"), @@ -74,15 +77,18 @@ ColumnLayout { } delegate: FormCard.FormButtonDelegate { - text: model.type - description: i18ncp("'Event' being some JSON data, not something physically happening.", "%1 event of this type", "%1 events of this type", model.eventCount) + required property string type + required property int eventCount + required property string stateKey + text: type + description: i18ncp("'Event' being some JSON data, not something physically happening.", "%1 event of this type", "%1 events of this type", eventCount) onClicked: { - if (model.eventCount === 1) { - openEventSource(model.type, model.stateKey); + if (eventCount === 1) { + root.openEventSource(type, stateKey); } else { - root.Window.window.pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat.devtools', 'StateKeys'), { + (root.Kirigami.PageStack.pageStack as Kirigami.PageRow).pushDialogLayer(Qt.createComponent('org.kde.neochat.devtools', 'StateKeys'), { room: root.room, - eventType: model.type + eventType: type }, { title: i18nc("'Event' being some JSON data, not something physically happening.", "Event Information") }); @@ -92,7 +98,7 @@ ColumnLayout { } } function openEventSource(type: string, stateKey: string): void { - onClicked: root.Window.window.pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat', 'MessageSourceSheet'), { + onClicked: (root.Kirigami.PageStack.pageStack as Kirigami.PageRow).pushDialogLayer(Qt.createComponent('org.kde.neochat', 'MessageSourceSheet'), { model: stateModel, allowEdit: true, room: root.room,