ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DevicesModel: Do not connect until the value is initialised

Browse Source 
When the DevicesModel is open, we get a nullptr instance. I guess it's
obvious that it's null because it hasn't been set yet. Move the connect
to the setter.
This commit is contained in:
Aleix Pol
2025-06-13 03:18:01 +02:00
committed by Aleix Pol Gonzalez
parent 7a6c234b40
commit aea9984187
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/settings/models/devicesmodel.cpp
View File

@@ -18,15 +18,6 @@ using namespace Quotient;
DevicesModel::DevicesModel(QObject *parent) DevicesModel::DevicesModel(QObject *parent)
: QAbstractListModel(parent) : QAbstractListModel(parent)
{ {
connect(m_connection, &Connection::sessionVerified, this, [this](const QString &, const QString &deviceId) {
const auto it = std::find_if(m_devices.begin(), m_devices.end(), [deviceId](const Quotient::Device &device) {
return device.deviceId == deviceId;
});
if (it != m_devices.end()) {
const auto index = this->index(it - m_devices.begin());
Q_EMIT dataChanged(index, index, {Type});
}
});
} }
void DevicesModel::fetchDevices() void DevicesModel::fetchDevices()
@@ -162,6 +153,15 @@ void DevicesModel::setConnection(NeoChatConnection *connection)
disconnect(m_connection, nullptr, this, nullptr); disconnect(m_connection, nullptr, this, nullptr);
} }
m_connection = connection; m_connection = connection;
connect(m_connection, &Connection::sessionVerified, this, [this](const QString &, const QString &deviceId) {
const auto it = std::find_if(m_devices.begin(), m_devices.end(), [deviceId](const Quotient::Device &device) {
return device.deviceId == deviceId;
});
if (it != m_devices.end()) {
const auto index = this->index(it - m_devices.begin());
Q_EMIT dataChanged(index, index, {Type});
}
});
Q_EMIT connectionChanged(); Q_EMIT connectionChanged();
fetchDevices(); fetchDevices();