From b1e54a834caa9595da94366463b549cd53c7ee52 Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Fri, 22 Nov 2024 09:22:06 -0500 Subject: [PATCH] Fix capitalization of labels under General Settings Buttons should be title case, and form headers should be sentence case. Also, add an icon to the "Reset to defaults" button. --- src/settings/AppearanceSettingsPage.qml | 2 +- src/settings/NeoChatGeneralPage.qml | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/settings/AppearanceSettingsPage.qml b/src/settings/AppearanceSettingsPage.qml index 05e17e20e..392242ef7 100644 --- a/src/settings/AppearanceSettingsPage.qml +++ b/src/settings/AppearanceSettingsPage.qml @@ -18,7 +18,7 @@ FormCard.FormCardPage { title: i18nc("@title:window", "Appearance") FormCard.FormHeader { - title: i18n("General theme") + title: i18nc("@title:group", "General Theme") } FormCard.FormCard { FormCard.AbstractFormDelegate { diff --git a/src/settings/NeoChatGeneralPage.qml b/src/settings/NeoChatGeneralPage.qml index 1e16a7154..4817663a2 100644 --- a/src/settings/NeoChatGeneralPage.qml +++ b/src/settings/NeoChatGeneralPage.qml @@ -20,7 +20,7 @@ FormCard.FormCardPage { title: i18nc("@title:window", "General") FormCard.FormHeader { - title: i18n("General settings") + title: i18nc("@title:group", "General Settings") visible: Qt.platform.os !== "android" } FormCard.FormCard { @@ -88,7 +88,7 @@ FormCard.FormCardPage { } FormCard.FormHeader { - title: i18n("Room list sort order") + title: i18nc("@title:group", "Room List Sort Order") } FormCard.FormCard { FormCard.FormRadioDelegate { @@ -273,7 +273,7 @@ FormCard.FormCardPage { id: openDeveloperToolsDelegate visible: NeoChatConfig.developerTools icon.name: "tools" - text: i18n("Open developer tools") + text: i18n("Open Developer Tools") onClicked: root.QQC2.ApplicationWindow.window.pageStack.pushDialogLayer(Qt.createComponent('org.kde.neochat.devtools', 'DevtoolsPage'), { connection: root.connection }, { @@ -282,11 +282,12 @@ FormCard.FormCardPage { } } FormCard.FormHeader { - title: i18nc("@title", "Default Settings") + title: i18nc("@title:group", "Default Settings") } FormCard.FormCard { FormCard.FormButtonDelegate { - text: i18nc("@action:button", "Reset all configuration values to their default") + icon.name: "kt-restore-defaults-symbolic" + text: i18nc("@action:button", "Reset All Configuration Values to Their Default") onClicked: Controller.revertToDefaultConfig() } }