From b2af69fd929a63a22f840a1760c400ddc4efbf3a Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Sat, 20 Jan 2024 14:34:18 -0500 Subject: [PATCH] Make the settings window a little bit taller to accommodate most pages According to the HIG, scrolling should be kept to a minimum on settings dialogs. The default window size for the dialog is too small on desktop, and usually needs to be resized to prevent scrolling. --- src/qml/AccountMenu.qml | 8 ++++++-- src/qml/GlobalMenu.qml | 4 +++- src/qml/UserInfo.qml | 4 +++- src/qml/main.qml | 4 +++- 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/qml/AccountMenu.qml b/src/qml/AccountMenu.qml index 87a148710..8b0dee5ef 100644 --- a/src/qml/AccountMenu.qml +++ b/src/qml/AccountMenu.qml @@ -33,7 +33,9 @@ QQC2.Menu { defaultPage: "notifications", connection: root.connection }, { - title: i18n("Configure") + title: i18n("Configure"), + width: Kirigami.Units.gridUnit * 50, + height: Kirigami.Units.gridUnit * 42 }) } QQC2.MenuItem { @@ -43,7 +45,9 @@ QQC2.Menu { defaultPage: "devices", connection: root.connection }, { - title: i18n("Configure") + title: i18n("Configure"), + width: Kirigami.Units.gridUnit * 50, + height: Kirigami.Units.gridUnit * 42 }) } QQC2.MenuItem { diff --git a/src/qml/GlobalMenu.qml b/src/qml/GlobalMenu.qml index 5b1ee2d0b..bb2b4eb57 100644 --- a/src/qml/GlobalMenu.qml +++ b/src/qml/GlobalMenu.qml @@ -31,7 +31,9 @@ Labs.MenuBar { onTriggered: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { connection: root.connection }, { - title: i18n("Configure") + title: i18n("Configure"), + width: Kirigami.Units.gridUnit * 50, + height: Kirigami.Units.gridUnit * 42 }) } Labs.MenuItem { diff --git a/src/qml/UserInfo.qml b/src/qml/UserInfo.qml index b3d2cb8f7..87026b1d2 100644 --- a/src/qml/UserInfo.qml +++ b/src/qml/UserInfo.qml @@ -123,7 +123,9 @@ RowLayout { onClicked: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { connection: root.connection }, { - title: i18n("Configure") + title: i18n("Configure"), + width: Kirigami.Units.gridUnit * 50, + height: Kirigami.Units.gridUnit * 42 }) text: i18n("Open Settings") display: QQC2.AbstractButton.IconOnly diff --git a/src/qml/main.qml b/src/qml/main.qml index a2af797e7..b68af2276 100644 --- a/src/qml/main.qml +++ b/src/qml/main.qml @@ -442,7 +442,9 @@ Kirigami.ApplicationWindow { pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { connection: root.connection }, { - title: i18n("Configure") + title: i18n("Configure"), + width: Kirigami.Units.gridUnit * 50, + height: Kirigami.Units.gridUnit * 42 }); } }