ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix message hover buttons (React, Edit, Reply) not moving with scroll

Browse Source 
Fix #296
This commit is contained in:
Carl Schwan
2021-03-18 01:56:27 +01:00
parent 8e5ca78249
commit b349c2376d
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
imports/NeoChat/Component/Timeline/TimelineContainer.qml
View File

@@ -46,8 +46,9 @@ Item {
// show hover actions // show hover actions
onHoveredChanged: { onHoveredChanged: {
if (hovered && !Kirigami.Settings.isMobile) { if (hovered && !Kirigami.Settings.isMobile) {
hoverComponent.x = Qt.binding(() => column.mapToItem(page, hoverComponentX, hoverComponentY).x); hoverComponent.parent = controlContainer;
hoverComponent.y = Qt.binding(() => column.mapToItem(page, hoverComponentX, hoverComponentY).y); hoverComponent.x = Qt.binding(() => controlContainer.width - hoverComponent.childWidth)
hoverComponent.y = -Kirigami.Units.largeSpacing * 4
hoverComponent.hovered = Qt.binding(() => controlContainer.hovered); hoverComponent.hovered = Qt.binding(() => controlContainer.hovered);
hoverComponent.showEdit = author.id === Controller.activeConnection.localUserId && (model.eventType === "emote" || model.eventType === "message"); hoverComponent.showEdit = author.id === Controller.activeConnection.localUserId && (model.eventType === "emote" || model.eventType === "message");

6
imports/NeoChat/Page/RoomPage.qml
View File

@@ -129,7 +129,7 @@ Kirigami.ScrollablePage {
} }
// hover actions on a delegate, activated in TimelineContainer.qml // hover actions on a delegate, activated in TimelineContainer.qml
Item { QQC2.Popup {
id: hoverActions id: hoverActions
property bool showEdit property bool showEdit
property bool hovered: false property bool hovered: false
@@ -143,7 +143,9 @@ Kirigami.ScrollablePage {
property alias childWidth: hoverActionsRow.width property alias childWidth: hoverActionsRow.width
property alias childHeight: hoverActionsRow.height property alias childHeight: hoverActionsRow.height
RowLayout { background: Item {}
contentItem: RowLayout {
id: hoverActionsRow id: hoverActionsRow
z: 4 z: 4
spacing: 0 spacing: 0