From ba24f1272fb75d230d57f0e350b3a8164ab13769 Mon Sep 17 00:00:00 2001 From: Tobias Fella Date: Sat, 23 Sep 2023 10:36:06 +0200 Subject: [PATCH] Fix crash in completion --- src/models/completionmodel.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/models/completionmodel.cpp b/src/models/completionmodel.cpp index dca0c7732..1f0443ae5 100644 --- a/src/models/completionmodel.cpp +++ b/src/models/completionmodel.cpp @@ -87,8 +87,11 @@ QVariant CompletionModel::data(const QModelIndex &index, int role) const return m_filterModel->data(filterIndex, RoomListModel::CanonicalAliasRole); } if (role == IconNameRole) { - return QStringLiteral("mxc://%1") - .arg(m_roomListModel->connection()->makeMediaUrl(m_filterModel->data(filterIndex, RoomListModel::AvatarRole).toUrl()).toString()); + auto mediaId = m_filterModel->data(filterIndex, RoomListModel::AvatarRole).toString(); + if (mediaId.isEmpty()) { + return QVariant(); + } + return m_room->connection()->makeMediaUrl(QUrl(QStringLiteral("mxc://%1").arg(mediaId))); } } if (m_autoCompletionType == Emoji) {