ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Regularize context menu

Browse Source 
"Open in new Window" goes on top, as it does in most other context menus
with similar items

"Leave room" goes on the bottom with a separator above it, because it's
a mildly destructive action.
This commit is contained in:
Nate Graham
2021-01-14 08:16:55 -07:00
parent 085ebaa451
commit bd11f543f5
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
imports/NeoChat/Menu/RoomListContextMenu.qml
View File

@@ -15,6 +15,13 @@ Menu {
id: root id: root
property var room property var room
MenuItem {
text: i18n("Open in new window")
onTriggered: roomManager.openWindow(room);
}
MenuSeparator {}
MenuItem { MenuItem {
text: room.isFavourite ? i18n("Remove from Favourites") : i18n("Add to Favourites") text: room.isFavourite ? i18n("Remove from Favourites") : i18n("Add to Favourites")
@@ -27,8 +34,6 @@ Menu {
onTriggered: room.isLowPriority ? room.removeTag("m.lowpriority") : room.addTag("m.lowpriority", 1.0) onTriggered: room.isLowPriority ? room.removeTag("m.lowpriority") : room.addTag("m.lowpriority", 1.0)
} }
MenuSeparator {}
MenuItem { MenuItem {
text: i18n("Mark as Read") text: i18n("Mark as Read")
@@ -42,12 +47,5 @@ Menu {
onTriggered: room.forget() onTriggered: room.forget()
} }
MenuSeparator {}
MenuItem {
text: i18n("Open in new window")
onTriggered: roomManager.openWindow(room);
}
onClosed: destroy() onClosed: destroy()
} }