From c105170eca01904146b7f4e9aa505d5f044ef6ab Mon Sep 17 00:00:00 2001 From: Thiago Sueto Date: Sat, 16 Nov 2024 14:37:01 +0000 Subject: [PATCH] Make top margin consistent across Neochat settings This standardizes on the same value used for KirigamiAddons pages like AboutKDE and About, namely largeSpacing * 4. Now, when switching between settings pages you no longer have settings inconsistently changing heights willy nilly, header notwithstanding. The only page that's missing is the Spellchecking page, as that needs to be fixed in Kirigami Addons' private Sonnet page. (cherry picked from commit 396cc8e8efd15b810d8ba50e3146da96011a4e27) --- src/settings/GlobalNotificationsPage.qml | 2 +- src/settings/NeoChatSecurityPage.qml | 2 +- src/settings/NetworkProxyPage.qml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/settings/GlobalNotificationsPage.qml b/src/settings/GlobalNotificationsPage.qml index dc855cdbf..57f2c4200 100644 --- a/src/settings/GlobalNotificationsPage.qml +++ b/src/settings/GlobalNotificationsPage.qml @@ -23,7 +23,7 @@ FormCard.FormCardPage { } FormCard.FormCard { - Layout.topMargin: Kirigami.Units.largeSpacing + Layout.topMargin: Kirigami.Units.largeSpacing * 4 FormCard.FormCheckDelegate { text: i18n("Enable notifications for this account") description: i18n("Whether push notifications are generated by your Matrix server") diff --git a/src/settings/NeoChatSecurityPage.qml b/src/settings/NeoChatSecurityPage.qml index 6d3390335..0925efa7b 100644 --- a/src/settings/NeoChatSecurityPage.qml +++ b/src/settings/NeoChatSecurityPage.qml @@ -26,7 +26,7 @@ FormCard.FormCardPage { } FormCard.FormCard { - Layout.topMargin: Kirigami.Units.largeSpacing + Layout.topMargin: Kirigami.Units.largeSpacing * 4 FormCard.FormButtonDelegate { id: ignoredUsersDelegate text: i18nc("@action:button", "Ignored Users") diff --git a/src/settings/NetworkProxyPage.qml b/src/settings/NetworkProxyPage.qml index 2b2aced2b..a44ca4b4e 100644 --- a/src/settings/NetworkProxyPage.qml +++ b/src/settings/NetworkProxyPage.qml @@ -16,7 +16,7 @@ FormCard.FormCardPage { property bool proxyConfigChanged: false FormCard.FormCard { - Layout.topMargin: Kirigami.Units.largeSpacing + Layout.topMargin: Kirigami.Units.largeSpacing * 4 FormCard.FormRadioDelegate { id: systemDefault