From cd257137baf727722ab32329fd122775ba404bcf Mon Sep 17 00:00:00 2001 From: James Graham Date: Sun, 20 Nov 2022 16:48:36 +0000 Subject: [PATCH] Fix typing indicator causing markAllMessagesAsRead Move the typing indicator out of the listView header so it doesn't resize the view when appearing and disappearing causing all messages to be marked as read BUG: 457666 --- src/qml/Page/RoomPage.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qml/Page/RoomPage.qml b/src/qml/Page/RoomPage.qml index 647ca0d3a..fb99adccc 100644 --- a/src/qml/Page/RoomPage.qml +++ b/src/qml/Page/RoomPage.qml @@ -429,7 +429,7 @@ Kirigami.ScrollablePage { UserDetailDialog {} } - header: TypingPane { + TypingPane { id: typingPane visible: !loadingIndicator.visible && currentRoom && currentRoom.usersTyping.length > 0 labelText: visible ? i18ncp( @@ -438,6 +438,7 @@ Kirigami.ScrollablePage { currentRoom.usersTyping.map(user => user.displayName).join(", ") ) : "" anchors.left: parent.left + anchors.bottom: parent.bottom height: visible ? implicitHeight : 0 Behavior on height { NumberAnimation { @@ -448,7 +449,6 @@ Kirigami.ScrollablePage { } z: 2 } - headerPositioning: ListView.OverlayHeader function goToEvent(eventID) { const index = eventToIndex(eventID)