Don't abandon job when image request is cancelled

Aborting the request causes a lot of logged messages. In theory, not stopping the job causes some overhead,
but that's negligible and the provider is on its way out anyway.
This commit is contained in:
Tobias Fella
2023-04-25 15:19:49 +02:00
parent 77b2186cb6
commit cdf2c390ca
2 changed files with 0 additions and 19 deletions

View File

@@ -98,18 +98,6 @@ void ThumbnailResponse::prepareResult()
Q_EMIT finished();
}
void ThumbnailResponse::doCancel()
{
if (!Controller::instance().activeConnection()) {
return;
}
// Runs in the main thread, not QML thread
if (job) {
Q_ASSERT(QThread::currentThread() == job->thread());
job->abandon();
}
}
QQuickTextureFactory *ThumbnailResponse::textureFactory() const
{
QReadLocker _(&lock);
@@ -122,11 +110,6 @@ QString ThumbnailResponse::errorString() const
return errorStr;
}
void ThumbnailResponse::cancel()
{
QMetaObject::invokeMethod(this, &ThumbnailResponse::doCancel, Qt::QueuedConnection);
}
QQuickImageResponse *MatrixImageProvider::requestImageResponse(const QString &id, const QSize &requestedSize)
{
return new ThumbnailResponse(id, requestedSize);