From e342de3bc1a12049c6f641f24318f2184ff5ec84 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Mon, 1 Apr 2024 11:31:06 -0600 Subject: [PATCH] Make ConfirmUrlDialog HIG-compliant * "URL" is an acronym; make it all caps * Use descriptive context-appropriate buttons instead of "Yes" and "No" * Use KUIT markup for styling the link --- src/qml/ConfirmUrlDialog.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qml/ConfirmUrlDialog.qml b/src/qml/ConfirmUrlDialog.qml index f874b053b..434f408c0 100644 --- a/src/qml/ConfirmUrlDialog.qml +++ b/src/qml/ConfirmUrlDialog.qml @@ -14,11 +14,11 @@ Kirigami.Dialog { width: Kirigami.Units.gridUnit * 24 height: Kirigami.Units.gridUnit * 8 - title: i18nc("@title", "Open Url") - standardButtons: Kirigami.Dialog.Yes | Kirigami.Dialog.No + title: i18nc("@title", "Open URL") + standardButtons: QQC2.DialogButtonBox.Open | QQC2.DialogButtonBox.Cancel contentItem: QQC2.Label { - text: i18nc("Do you want to open ", "Do you want to open %1?", root.link) + text: xi18nc("@info", "Do you want to open %1?", root.link) wrapMode: QQC2.Label.Wrap horizontalAlignment: Qt.AlignHCenter verticalAlignment: Qt.AlignVCenter