ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve the design of the room notifications settings

Browse Source 
Now it has icons that match what we have in the room menu, and the
duplicate header text is removed.
This commit is contained in:
Joshua Goins
2025-07-16 17:59:16 -04:00
parent 069e0d8f16
commit f009420c20
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/rooms/RoomContextMenu.qml
View File

@@ -71,7 +71,7 @@ KirigamiComponents.ConvergentContextMenu {
} }
Kirigami.Action { Kirigami.Action {
text: i18nc("As in 'notify for all messages'", "All") text: i18nc("As in 'notify for all messages'", "All Messages")
icon.name: "notifications" icon.name: "notifications"
checkable: true checkable: true
autoExclusive: true autoExclusive: true
@@ -95,7 +95,7 @@ KirigamiComponents.ConvergentContextMenu {
} }
Kirigami.Action { Kirigami.Action {
text: i18nc("As in 'do not notify for any messages'", "Off") text: i18nc("As in 'do not notify for any messages'", "None")
icon.name: "notifications-disabled" icon.name: "notifications-disabled"
checkable: true checkable: true
autoExclusive: true autoExclusive: true

10
src/settings/PushNotification.qml
View File

@@ -23,11 +23,12 @@ FormCard.FormCardPage {
title: i18nc('@title:window', 'Notifications') title: i18nc('@title:window', 'Notifications')
FormCard.FormHeader { FormCard.FormHeader {
title: i18nc("@title:group", "Room notifications setting") title: i18nc("@title:group", "Send Notifications For")
} }
FormCard.FormCard { FormCard.FormCard {
FormCard.FormRadioDelegate { FormCard.FormRadioDelegate {
icon.name: "globe"
text: i18nc("As in the default notification setting", "Default Settings") text: i18nc("As in the default notification setting", "Default Settings")
checked: room.pushNotificationState === PushNotificationState.Default checked: room.pushNotificationState === PushNotificationState.Default
enabled: room.pushNotificationState !== PushNotificationState.Unknown enabled: room.pushNotificationState !== PushNotificationState.Unknown
@@ -36,7 +37,8 @@ FormCard.FormCardPage {
} }
} }
FormCard.FormRadioDelegate { FormCard.FormRadioDelegate {
text: i18nc("As in 'notify for all messages'", "All") icon.name: "notifications"
text: i18nc("As in 'notify for all messages'", "All Messages")
checked: room.pushNotificationState === PushNotificationState.All checked: room.pushNotificationState === PushNotificationState.All
enabled: room.pushNotificationState !== PushNotificationState.Unknown enabled: room.pushNotificationState !== PushNotificationState.Unknown
onToggled: { onToggled: {
@@ -44,6 +46,7 @@ FormCard.FormCardPage {
} }
} }
FormCard.FormRadioDelegate { FormCard.FormRadioDelegate {
icon.name: "im-user"
text: i18nc("As in 'notify when the user is mentioned or the message contains a set keyword'", "@Mentions and Keywords") text: i18nc("As in 'notify when the user is mentioned or the message contains a set keyword'", "@Mentions and Keywords")
checked: room.pushNotificationState === PushNotificationState.MentionKeyword checked: room.pushNotificationState === PushNotificationState.MentionKeyword
enabled: room.pushNotificationState !== PushNotificationState.Unknown enabled: room.pushNotificationState !== PushNotificationState.Unknown
@@ -52,7 +55,8 @@ FormCard.FormCardPage {
} }
} }
FormCard.FormRadioDelegate { FormCard.FormRadioDelegate {
text: i18nc("As in 'do not notify for any messages'", "Off") icon.name: "notifications-disabled"
text: i18nc("As in 'do not notify for any messages'", "None")
checked: room.pushNotificationState === PushNotificationState.Mute checked: room.pushNotificationState === PushNotificationState.Mute
enabled: room.pushNotificationState !== PushNotificationState.Unknown enabled: room.pushNotificationState !== PushNotificationState.Unknown
onToggled: { onToggled: {