From f89cec9c556690607e563d6215f2729ede862368 Mon Sep 17 00:00:00 2001 From: James Graham Date: Thu, 19 Sep 2024 17:18:25 +0000 Subject: [PATCH] Make sure that m_components cannot be accessed out of bounds in closeLinkPreview https://crash-reports.kde.org/organizations/kde/issues/67352/?project=18&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=5 --- src/models/messagecontentmodel.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/models/messagecontentmodel.cpp b/src/models/messagecontentmodel.cpp index ed8ad5415..a376656aa 100644 --- a/src/models/messagecontentmodel.cpp +++ b/src/models/messagecontentmodel.cpp @@ -634,6 +634,11 @@ QList MessageContentModel::addLinkPreviews(QList m_components.size()) { + qWarning() << "closeLinkPreview() called with row" << row << "which does not exist. m_components.size() =" << m_components.size(); + return; + } + if (m_components[row].type == MessageComponentType::LinkPreview || m_components[row].type == MessageComponentType::LinkPreviewLoad) { beginResetModel(); m_removedLinkPreviews += m_components[row].attributes["link"_ls].toUrl();