Compare commits

...

1 Commits

Author SHA1 Message Date
ivan tkachenko
d08e989695 TimelineView: Improve UX of "jump-to" round buttons
They are not meant to be focused or interacted via keyboard. Besides,
our default qqc2-desktop-style looks too bright and flashy for no reason.

Also set text on the action itself for accessibility reasons, but force
display mode at IconOnly.
2023-09-23 19:39:29 +00:00

View File

@@ -134,23 +134,25 @@ QQC2.ScrollView {
implicitWidth: Kirigami.Units.gridUnit * 2 implicitWidth: Kirigami.Units.gridUnit * 2
implicitHeight: Kirigami.Units.gridUnit * 2 implicitHeight: Kirigami.Units.gridUnit * 2
display: QQC2.AbstractButton.IconOnly
focusPolicy: Qt.NoFocus
z: 2 z: 2
visible: root.currentRoom && root.currentRoom.hasUnreadMessages && root.currentRoom.readMarkerLoaded visible: root.currentRoom && root.currentRoom.hasUnreadMessages && root.currentRoom.readMarkerLoaded
action: Kirigami.Action { action: Kirigami.Action {
icon.name: "go-up"
shortcut: "Shift+PgUp"
text: i18n("Jump to first unread message")
onTriggered: { onTriggered: {
if (!Kirigami.Settings.isMobile) { if (!Kirigami.Settings.isMobile) {
root.focusChatBox(); root.focusChatBox();
} }
messageListView.goToEvent(root.currentRoom.readMarkerEventId) messageListView.goToEvent(root.currentRoom.readMarkerEventId)
} }
icon.name: "go-up"
shortcut: "Shift+PgUp"
}
QQC2.ToolTip {
text: i18n("Jump to first unread message")
} }
} }
QQC2.RoundButton { QQC2.RoundButton {
id: goMarkAsReadFab id: goMarkAsReadFab
anchors.right: parent.right anchors.right: parent.right
@@ -160,18 +162,19 @@ QQC2.ScrollView {
implicitWidth: Kirigami.Units.gridUnit * 2 implicitWidth: Kirigami.Units.gridUnit * 2
implicitHeight: Kirigami.Units.gridUnit * 2 implicitHeight: Kirigami.Units.gridUnit * 2
display: QQC2.AbstractButton.IconOnly
focusPolicy: Qt.NoFocus
z: 2 z: 2
visible: !messageListView.atYEnd visible: !messageListView.atYEnd
action: Kirigami.Action { action: Kirigami.Action {
icon.name: "go-down"
text: i18n("Jump to latest message")
onTriggered: { onTriggered: {
messageListView.goToLastMessage(); messageListView.goToLastMessage();
root.currentRoom.markAllMessagesAsRead(); root.currentRoom.markAllMessagesAsRead();
} }
icon.name: "go-down"
}
QQC2.ToolTip {
text: i18n("Jump to latest message")
} }
} }