ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NotificationsManager: Improve function parameters

Browse Source
This commit is contained in:
Tobias Fella
2026-01-21 12:26:16 +01:00
committed by Tobias Fella
parent bf41e1083d
commit 0a7978f4f5
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/app/notificationsmanager.cpp
View File

@@ -38,7 +38,7 @@ NotificationsManager::NotificationsManager(QObject *parent)
{ {
} }
void NotificationsManager::handleNotifications(QPointer<NeoChatConnection> connection) void NotificationsManager::handleNotifications(const QPointer<NeoChatConnection> &connection)
{ {
if (KNotificationPermission::checkPermission() == Qt::PermissionStatus::Granted) { if (KNotificationPermission::checkPermission() == Qt::PermissionStatus::Granted) {
startNotificationJob(connection); startNotificationJob(connection);
@@ -68,7 +68,7 @@ void NotificationsManager::startNotificationJob(QPointer<NeoChatConnection> conn
} }
} }
void NotificationsManager::processNotificationJob(QPointer<NeoChatConnection> connection, Quotient::GetNotificationsJob *job, bool initialization) void NotificationsManager::processNotificationJob(const QPointer<NeoChatConnection> &connection, const GetNotificationsJob *job, const bool initialization)
{ {
if (!job || !connection || !connection->isLoggedIn()) { if (!job || !connection || !connection->isLoggedIn()) {
return; return;
@@ -159,7 +159,7 @@ void NotificationsManager::processNotificationJob(QPointer<NeoChatConnection> co
} }
} }
bool NotificationsManager::shouldPostNotification(QPointer<NeoChatConnection> connection, const QJsonValue &notification) bool NotificationsManager::shouldPostNotification(const QPointer<NeoChatConnection> &connection, const QJsonValue &notification)
{ {
if (connection == nullptr || !connection->isLoggedIn()) { if (connection == nullptr || !connection->isLoggedIn()) {
return false; return false;
@@ -198,7 +198,7 @@ void NotificationsManager::postNotification(NeoChatRoom *room,
const QString &text, const QString &text,
const QImage &icon, const QImage &icon,
const QString &replyEventId, const QString &replyEventId,
bool canReply, const bool canReply,
qint64 timestamp) qint64 timestamp)
{ {
const QString roomId = room->id(); const QString roomId = room->id();
@@ -283,7 +283,7 @@ void NotificationsManager::postInviteNotification(NeoChatRoom *rawRoom)
} }
} }
void NotificationsManager::doPostInviteNotification(QPointer<NeoChatRoom> room) void NotificationsManager::doPostInviteNotification(const QPointer<NeoChatRoom> &room)
{ {
const auto roomMemberEvent = room->currentState().get<RoomMemberEvent>(room->localMember().id()); const auto roomMemberEvent = room->currentState().get<RoomMemberEvent>(room->localMember().id());
if (roomMemberEvent == nullptr) { if (roomMemberEvent == nullptr) {

8
src/app/notificationsmanager.h
View File

@@ -58,7 +58,7 @@ public:
/** /**
* @brief Handle the notifications for the given connection. * @brief Handle the notifications for the given connection.
*/ */
void handleNotifications(QPointer<NeoChatConnection> connection); void handleNotifications(const QPointer<NeoChatConnection> &connection);
private: private:
QHash<QString, qint64> m_initialTimestamp; QHash<QString, qint64> m_initialTimestamp;
@@ -68,7 +68,7 @@ private:
void startNotificationJob(QPointer<NeoChatConnection> connection); void startNotificationJob(QPointer<NeoChatConnection> connection);
static QPixmap createNotificationImage(const QImage &icon, NeoChatRoom *room); static QPixmap createNotificationImage(const QImage &icon, NeoChatRoom *room);
bool shouldPostNotification(QPointer<NeoChatConnection> connection, const QJsonValue &notification); bool shouldPostNotification(const QPointer<NeoChatConnection> &connection, const QJsonValue &notification);
void postNotification(NeoChatRoom *room, void postNotification(NeoChatRoom *room,
const QString &sender, const QString &sender,
const QString &text, const QString &text,
@@ -77,7 +77,7 @@ private:
bool canReply, bool canReply,
qint64 timestamp); qint64 timestamp);
void doPostInviteNotification(QPointer<NeoChatRoom> room); void doPostInviteNotification(const QPointer<NeoChatRoom> &room);
QHash<QString, std::pair<qint64, KNotification *>> m_notifications; QHash<QString, std::pair<qint64, KNotification *>> m_notifications;
QHash<QString, QPointer<KNotification>> m_invitations; QHash<QString, QPointer<KNotification>> m_invitations;
@@ -85,5 +85,5 @@ private:
bool permissionAsked = false; bool permissionAsked = false;
private Q_SLOTS: private Q_SLOTS:
void processNotificationJob(QPointer<NeoChatConnection> connection, Quotient::GetNotificationsJob *job, bool initialization); void processNotificationJob(const QPointer<NeoChatConnection> &connection, const Quotient::GetNotificationsJob *job, bool initialization);
}; };