ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TextHandler: Use the fancy Unicode quotation characters

Browse Source 
As per our HIG, we should use these in quotations instead of the normal
quote characters.
This commit is contained in:
Joshua Goins
2024-11-16 15:52:39 -05:00
parent 3a9718c09d
commit 1104da5e2c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
autotests/texthandlertest.cpp
View File

@@ -535,7 +535,7 @@ void TextHandlerTest::componentOutput_data()
QVariantMap{{QStringLiteral("class"), QStringLiteral("html")}}}}; QVariantMap{{QStringLiteral("class"), QStringLiteral("html")}}}};
QTest::newRow("quote") << QStringLiteral("<p>Text</p>\n<blockquote>\n<p>blockquote</p>\n</blockquote>") QTest::newRow("quote") << QStringLiteral("<p>Text</p>\n<blockquote>\n<p>blockquote</p>\n</blockquote>")
<< QList<MessageComponent>{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}, << QList<MessageComponent>{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}},
MessageComponent{MessageComponentType::Quote, QStringLiteral("\"blockquote\""), {}}}; MessageComponent{MessageComponentType::Quote, QStringLiteral("“blockquote”"), {}}};
QTest::newRow("no tag first paragraph") << QStringLiteral("Text\n<p>Text</p>") QTest::newRow("no tag first paragraph") << QStringLiteral("Text\n<p>Text</p>")
<< QList<MessageComponent>{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}, << QList<MessageComponent>{MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}},
MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}}; MessageComponent{MessageComponentType::Text, QStringLiteral("Text"), {}}};

8
src/texthandler.cpp
View File

@@ -413,11 +413,11 @@ QString TextHandler::stripBlockTags(QString string, const QString &tagType) cons
string.remove(0, string.indexOf(u'>') + 1); string.remove(0, string.indexOf(u'>') + 1);
string.remove(string.indexOf(QLatin1String("</p>")), string.size()); string.remove(string.indexOf(QLatin1String("</p>")), string.size());
} }
if (!string.startsWith(u'"')) { if (!string.startsWith(u'“')) {
string.prepend(u'"'); string.prepend(u'“');
} }
if (!string.endsWith(u'"')) { if (!string.endsWith(u'”')) {
string.append(u'"'); string.append(u'”');
} }
} }