ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make the settings window a little bit taller to accommodate most pages

Browse Source 
According to the HIG, scrolling should be kept to a minimum on settings
dialogs. The default window size for the dialog is too small on desktop,
and usually needs to be resized to prevent scrolling.
This commit is contained in:
Joshua Goins
2024-01-20 14:34:18 -05:00
committed by Tobias Fella
parent ca57732871
commit b2af69fd92
4 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/qml/AccountMenu.qml
View File

@@ -33,7 +33,9 @@ QQC2.Menu {
defaultPage: "notifications", defaultPage: "notifications",
connection: root.connection connection: root.connection
}, { }, {
title: i18n("Configure") title: i18n("Configure"),
width: Kirigami.Units.gridUnit * 50,
height: Kirigami.Units.gridUnit * 42
}) })
} }
QQC2.MenuItem { QQC2.MenuItem {
@@ -43,7 +45,9 @@ QQC2.Menu {
defaultPage: "devices", defaultPage: "devices",
connection: root.connection connection: root.connection
}, { }, {
title: i18n("Configure") title: i18n("Configure"),
width: Kirigami.Units.gridUnit * 50,
height: Kirigami.Units.gridUnit * 42
}) })
} }
QQC2.MenuItem { QQC2.MenuItem {

4
src/qml/GlobalMenu.qml
View File

@@ -31,7 +31,9 @@ Labs.MenuBar {
onTriggered: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { onTriggered: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", {
connection: root.connection connection: root.connection
}, { }, {
title: i18n("Configure") title: i18n("Configure"),
width: Kirigami.Units.gridUnit * 50,
height: Kirigami.Units.gridUnit * 42
}) })
} }
Labs.MenuItem { Labs.MenuItem {

4
src/qml/UserInfo.qml
View File

@@ -123,7 +123,9 @@ RowLayout {
onClicked: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { onClicked: pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", {
connection: root.connection connection: root.connection
}, { }, {
title: i18n("Configure") title: i18n("Configure"),
width: Kirigami.Units.gridUnit * 50,
height: Kirigami.Units.gridUnit * 42
}) })
text: i18n("Open Settings") text: i18n("Open Settings")
display: QQC2.AbstractButton.IconOnly display: QQC2.AbstractButton.IconOnly

4
src/qml/main.qml
View File

@@ -442,7 +442,9 @@ Kirigami.ApplicationWindow {
pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", { pageStack.pushDialogLayer("qrc:/org/kde/neochat/qml/SettingsPage.qml", {
connection: root.connection connection: root.connection
}, { }, {
title: i18n("Configure") title: i18n("Configure"),
width: Kirigami.Units.gridUnit * 50,
height: Kirigami.Units.gridUnit * 42
}); });
} }
} }