Don't leak QSetting in emoji model
This commit is contained in:
@@ -11,7 +11,7 @@
|
||||
|
||||
QVariantList EmojiModel::history()
|
||||
{
|
||||
return m_settings->value("Editor/emojis", QVariantList()).toList();
|
||||
return m_settings.value("Editor/emojis", QVariantList()).toList();
|
||||
}
|
||||
|
||||
QVariantList EmojiModel::filterModel(const QString &filter)
|
||||
@@ -83,7 +83,7 @@ void EmojiModel::emojiUsed(QVariant modelData)
|
||||
}
|
||||
|
||||
list.push_front(modelData);
|
||||
m_settings->setValue("Editor/emojis", list);
|
||||
m_settings.setValue("Editor/emojis", list);
|
||||
|
||||
Q_EMIT historyChanged();
|
||||
}
|
||||
|
||||
@@ -63,7 +63,6 @@ class EmojiModel : public QObject
|
||||
public:
|
||||
explicit EmojiModel(QObject *parent = nullptr)
|
||||
: QObject(parent)
|
||||
, m_settings(new QSettings())
|
||||
{
|
||||
}
|
||||
|
||||
@@ -86,7 +85,7 @@ private:
|
||||
static const QVariantList symbols;
|
||||
static const QVariantList flags;
|
||||
|
||||
QSettings *m_settings;
|
||||
QSettings m_settings;
|
||||
};
|
||||
|
||||
#endif // EMOJIMODEL_H
|
||||
|
||||
Reference in New Issue
Block a user