ESCA111/neochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't leak QSetting in emoji model

Browse Source
This commit is contained in:
Carl Schwan
2020-11-22 11:56:19 +01:00
parent 816fc0aa25
commit 59ae9fa18d
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/emojimodel.cpp
View File

@@ -11,7 +11,7 @@
QVariantList EmojiModel::history() QVariantList EmojiModel::history()
{ {
return m_settings->value("Editor/emojis", QVariantList()).toList(); return m_settings.value("Editor/emojis", QVariantList()).toList();
} }
QVariantList EmojiModel::filterModel(const QString &filter) QVariantList EmojiModel::filterModel(const QString &filter)
@@ -83,7 +83,7 @@ void EmojiModel::emojiUsed(QVariant modelData)
} }
list.push_front(modelData); list.push_front(modelData);
m_settings->setValue("Editor/emojis", list); m_settings.setValue("Editor/emojis", list);
Q_EMIT historyChanged(); Q_EMIT historyChanged();
} }

3
src/emojimodel.h
View File

@@ -63,7 +63,6 @@ class EmojiModel : public QObject
public: public:
explicit EmojiModel(QObject *parent = nullptr) explicit EmojiModel(QObject *parent = nullptr)
: QObject(parent) : QObject(parent)
, m_settings(new QSettings())
{ {
} }
@@ -86,7 +85,7 @@ private:
static const QVariantList symbols; static const QVariantList symbols;
static const QVariantList flags; static const QVariantList flags;
QSettings *m_settings; QSettings m_settings;
}; };
#endif // EMOJIMODEL_H #endif // EMOJIMODEL_H