This was discovered none other than Bug Catcher Nate, while in the TWiKS
room. That room doesn't have a canonical alias set (yet) and that
exposed some UX problems around aliases in NeoChat.
First, the non-canonical alias isn't shown in the info drawer despite
being the only alias available. This is something that Element actually
does, and now NeoChat does too.
Second, NeoChat will try to copy the room's internal Matrix ID (which is
not that great) to the clipboard because it looks for the canonical
alias. Surprisingly, Element also does this but now NeoChat doesn't.
(cherry picked from commit 86fd2e8e1e)
As seen in the bug report, roomEvent could be null and then we get a
nice and simple null-access error. We should be careful before trying to
use it.
BUG: 502687
(cherry picked from commit a1513b30cd)
This prevents doing actions like zooming in your screen (Meta+Equals)
because it will tripper shortcutOverride and close the menu. Instead, we
shouldn't block shortcuts but still allow closing when Escape is
pressed.
This *does* block all NeoChat shortcuts when the completion menu is
open, but personally I think this is fine. If you have this open, you
really should finish your message first!
(cherry picked from commit fda84a6aac)
This was previously fixed to the size of the text area itself, which
could be small. We also have a bug where the text area *itself* is like
one character big, so this helps there too.
The popup is also given a margin of 0 so it is always positioned within
the bounds of the window.
BUG: 503483
(cherry picked from commit 142312d87d)
This only seems to happen when the window is maximized, specifically
the height of the window. This seems to be a weird TextArea issue (or
something else in our TimelineView) but until that's found out, a
Qt.callLater will prevent this annoying crash.
BUG: 503846
(cherry picked from commit 906fb97259)
This was incorrectly capitalized, so I just went ahead and properly
capitalized it so we stop making this mistake!
(cherry picked from commit 80923a2025)
They changed how margins behave when there's no navigation buttons in 7b02df40381b28de97fab1dd8d97182778c242df
so we are actually adding more padding ontop of the existing one.
(cherry picked from commit d51e68e9e2)
Co-authored-by: Joshua Goins <josh@redstrate.com>
Make sure that ChatDocumentHandler can handle the document being changed to a nullptr.
BUG: 501950
(cherry picked from commit 97d5be9d81)
3f287b20 Make sure that ChatDocumentHandler can handle the document being changed to a nullptr.
Co-authored-by: James Graham <james.h.graham@protonmail.com>
It seems like the case is possible as we already are treating the case
in isUserBanned. Doesn't seem ideal as it shows "" where the username
should be but it's better than a crash.
(cherry picked from commit df9a7292b9)
Co-authored-by: Aleix Pol <aleixpol@kde.org>
This is because we only check if the last message component != Text,
because that handles it's own edit strings. Quote components do that
too, so if we don't exclude it there ends up being two (edited) strings
in one message.
(cherry picked from commit 5ef4ab0756)
This was a mistake in the code that was designed to remove the outside
paragraphs, which seems to be to make way for the quotation marks we
add around the text. Instead of doing that (which turns out, is very
brittle and breaks on multiple paragraphs) insert the quotation marks
*inside* of the paragraph tags.
A test case is added for this as well.
(cherry picked from commit 704505958e)
We realized that images don't display in link previews anymore, because
QML is terrible and this property is a QUrl, so when we call .length it
silently fails and never loads the image. This is easily fixed by
calling .toString().
There's also another bug where the title ie elided way too greedily, but
we can simplify the elision check and fix the bug at the same time.
No more "Hom..."!
(cherry picked from commit 2546d79f26)
Our HIG explicitly says we can do this for links, and these components
are literally giant links. This might also help differentiate these from
similar looking components like quotes for desktop users.
(cherry picked from commit c3404936fd)
For long links, this ends up going "off" the window (not really of
course.) One good example is Bugzilla filter URLs which are ungodly
huge. So eliding these just makes it look better, browsers do this too.
(cherry picked from commit ec635d7de3)
